linux-kernel - Re: [PATCH v4 12/23] iommufd/driver: Add iommufd_hw_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCbEXj2gHJ41+aXq@Asurada-Nvidia>
Date: Thu, 15 May 2025 21:51:42 -0700
From: Nicolin Chen <nicolinc@...dia.com>
To: Jason Gunthorpe <jgg@...dia.com>
CC: <kevin.tian@...el.com>, <corbet@....net>, <will@...nel.org>,
	<bagasdotme@...il.com>, <robin.murphy@....com>, <joro@...tes.org>,
	<thierry.reding@...il.com>, <vdumpa@...dia.com>, <jonathanh@...dia.com>,
	<shuah@...nel.org>, <jsnitsel@...hat.com>, <nathan@...nel.org>,
	<peterz@...radead.org>, <yi.l.liu@...el.com>, <mshavit@...gle.com>,
	<praan@...gle.com>, <zhangzekun11@...wei.com>, <iommu@...ts.linux.dev>,
	<linux-doc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-tegra@...r.kernel.org>,
	<linux-kselftest@...r.kernel.org>, <patches@...ts.linux.dev>,
	<mochs@...dia.com>, <alok.a.tiwari@...cle.com>, <vasant.hegde@....com>
Subject: Re: [PATCH v4 12/23] iommufd/driver: Add
 iommufd_hw_queue_depend/undepend() helpers

On Thu, May 15, 2025 at 01:12:54PM -0300, Jason Gunthorpe wrote:
> On Thu, May 08, 2025 at 08:02:33PM -0700, Nicolin Chen wrote:
> 
> > +/*
> > + * Helpers for IOMMU driver to build/destroy a dependency between two sibling
> > + * structures created by one of the allocators above
> > + */
> > +#define iommufd_hw_queue_depend(dependent, depended, member)                   \
> > +	({                                                                     \
> > +		static_assert(__same_type(struct iommufd_hw_queue,             \
> > +					  dependent->member));                 \
> > +		static_assert(offsetof(typeof(*dependent), member.obj) == 0);  \
> > +		static_assert(__same_type(struct iommufd_hw_queue,             \
> > +					  depended->member));                  \
> > +		static_assert(offsetof(typeof(*depended), member.obj) == 0);   \
> > +		_iommufd_object_depend(&dependent->member.obj,                 \
> > +				       &depended->member.obj);                 \
> > +	})
> 
> This doesn't need the offsetof == 0 checks, it isn't an allocator. And
> you want to check that the two structs have the same type:
> 
> static_assert(__same_type(struct iommufd_hw_queue, dependent->member));
> static_assert(__same_type(typeof(*dependent), *dependend));

Ack. I also added ictx comparison:

+#define iommufd_hw_queue_depend(dependent, depended, member)                   \
+       ({                                                                     \
+               int ret = -EINVAL;                                             \
+                                                                              \
+               static_assert(__same_type(struct iommufd_hw_queue,             \
+                                         dependent->member));                 \
+               static_assert(__same_type(typeof(*dependent), *depended));     \
+               if (!WARN_ON_ONCE(dependent->member.ictx !=                    \
+                                 depended->member.ictx))                      \
+                       ret = _iommufd_object_depend(&dependent->member.obj,   \
+                                                    &depended->member.obj);   \
+               ret;                                                           \
+       })
+
+#define iommufd_hw_queue_undepend(dependent, depended, member)                 \
+       ({                                                                     \
+               static_assert(__same_type(struct iommufd_hw_queue,             \
+                                         dependent->member));                 \
+               static_assert(__same_type(typeof(*dependent), *depended));     \
+               WARN_ON_ONCE(dependent->member.ictx != depended->member.ictx); \
+               _iommufd_object_undepend(&dependent->member.obj,               \
+                                        &depended->member.obj);               \
+       })

Thanks
Nicolin