linux-kernel - Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL+tcoBtLu6_E1qKL9VHOiCe_RVpEGzMiMqA3GpPi1Z88aMiWw@mail.gmail.com>
Date: Fri, 16 May 2025 13:02:59 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: axboe@...nel.dk, rostedt@...dmis.org, mhiramat@...nel.org, 
	mathieu.desnoyers@...icios.com, akpm@...ux-foundation.org, 
	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, Jason Xing <kernelxing@...cent.com>, 
	Yushan Zhou <katrinzhou@...cent.com>
Subject: Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function

On Fri, May 16, 2025 at 12:37 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Thu, May 15, 2025 at 02:16:41PM +0800, Jason Xing wrote:
> > +extern size_t relay_dump(struct rchan *chan, int flags);
>
> Please don't add pointless externs for function prototypes.

Do you mean make it inline in include/linux/relay.h like how
relay_write() works?

Will do that.

>
> > +EXPORT_SYMBOL_GPL(relay_dump);
>
> This export seems unused even with the entire series applied.

My initial thought was to provide a symbol for some kernel modules to use.

Thanks,
Jason