linux-kernel - Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aCbH1eA8Iicg_Fq_@infradead.org>
Date: Thu, 15 May 2025 22:06:29 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: Christoph Hellwig <hch@...radead.org>, axboe@...nel.dk,
	rostedt@...dmis.org, mhiramat@...nel.org,
	mathieu.desnoyers@...icios.com, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org,
	Jason Xing <kernelxing@...cent.com>,
	Yushan Zhou <katrinzhou@...cent.com>
Subject: Re: [PATCH v2 2/4] relayfs: introduce dump of relayfs statistics
 function

On Fri, May 16, 2025 at 01:02:59PM +0800, Jason Xing wrote:
> Do you mean make it inline in include/linux/relay.h like how
> relay_write() works?
> 
> Will do that.

Just drop the extern, which is not needed:

size_t relay_dump(struct rchan *chan, int flags);

> >
> > This export seems unused even with the entire series applied.
> 
> My initial thought was to provide a symbol for some kernel modules to use.

The only user is blktrace, which can't be modular.  Or you plan to
submit a modular user soon, like in the next merge window/  If so
note that and add a pointer to it in the cover letter.