[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <db059233-523d-420b-81a7-73b02beef4d1@quicinc.com>
Date: Fri, 16 May 2025 15:34:28 +0800
From: Wenmeng Liu <quic_wenmliu@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
Konrad Dybcio
<konrad.dybcio@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, Depeng Shao <quic_depengs@...cinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss
On 2025/5/1 9:15, Bryan O'Donoghue wrote:
> On 30/04/2025 12:11, Konrad Dybcio wrote:
>> On 4/15/25 9:38 AM, Wenmeng Liu wrote:
>>> Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
>>> includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
>>>
>>> SM8550 provides
>>> - 3 x VFE, 3 RDI per VFE
>>> - 2 x VFE Lite, 4 RDI per VFE
>>> - 3 x CSID
>>> - 2 x CSID Lite
>>> - 8 x CSI PHY
>>>
>>> Co-developed-by: Depeng Shao <quic_depengs@...cinc.com>
>>> Signed-off-by: Depeng Shao <quic_depengs@...cinc.com>
>>> Signed-off-by: Wenmeng Liu <quic_wenmliu@...cinc.com>
>>> ---
>>
>> [...]
>>
>>> + <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
>>> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
>>
>> It *may* be 689 instead but I'm not 100% sure
>>
>> Otherwise the numbers look good
>>
>> Bryan, Vlad, please also take a look
>>
>> Konrad
>>
>
> + <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
> This should be 689 yes
>
> ---
> bod
Hi Bryan,Konrad,
I confirmed that the value is 688 instead of 689. The documentation
incorrectly listed it as 689. To CC linux-media, I have resent the patch:
https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-quic_wenmliu@quicinc.com/
Thanks,
wenmeng
Powered by blists - more mailing lists