linux-kernel - Re: [PATCH] scsi: ufs: mcq: delete ufshcd_release_scsi_cmd in ufshcd_mcq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63c8ec49f738157819568c6e8b4241913543b718.camel@mediatek.com>
Date: Fri, 16 May 2025 09:36:09 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "avri.altman@....com" <avri.altman@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"cw9316.lee@...sung.com" <cw9316.lee@...sung.com>, "chenyuan0y@...il.com"
	<chenyuan0y@...il.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "bvanassche@....org"
	<bvanassche@....org>, "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
	"ping.gao@...sung.com" <ping.gao@...sung.com>, "minwoo.im@...sung.com"
	<minwoo.im@...sung.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "James.Bottomley@...senPartnership.com"
	<James.Bottomley@...senPartnership.com>
Subject: Re: [PATCH] scsi: ufs: mcq: delete ufshcd_release_scsi_cmd in
 ufshcd_mcq_abort

On Fri, 2025-05-16 at 16:38 +0800, ping.gao wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> after ufs UFS_ABORT_TASK process successfully , host will generate
> mcq irq for abort tag with response OCS_ABORTED
> ufshcd_compl_one_cqe ->
>     ufshcd_release_scsi_cmd
> 
> But in ufshcd_mcq_abort already do ufshcd_release_scsi_cmd, this
> means
>  __ufshcd_release will be done twice.
> 
> This means hba->clk_gating.active_reqs also will be decrease twice,
> it
> will be negtive, so delete ufshcd_release_scsi_cmd in
> ufshcd_mcq_abort
> function.
> 
> static void __ufshcd_release(struct ufs_hba *hba)
> {
>     if (!ufshcd_is_clkgating_allowed(hba))
>         return;
> 
>     hba->clk_gating.active_reqs--;
> 
>     if (hba->clk_gating.active_reqs < 0) {
>         panic("ufs abnormal active_reqs!!!!!!");
>     }
> 
>     ...
> }
> Signed-off-by: ping.gao <ping.gao@...sung.com>
> ---
>  drivers/ufs/core/ufs-mcq.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c
> index f1294c29f484..2106c63db5ca 100644
> --- a/drivers/ufs/core/ufs-mcq.c
> +++ b/drivers/ufs/core/ufs-mcq.c
> @@ -713,10 +713,5 @@ int ufshcd_mcq_abort(struct scsi_cmnd *cmd)
>                 return FAILED;
>         }
> 
> -       spin_lock_irqsave(&hwq->cq_lock, flags);
> -       if (ufshcd_cmd_inflight(lrbp->cmd))
> -               ufshcd_release_scsi_cmd(hba, lrbp);
> -       spin_unlock_irqrestore(&hwq->cq_lock, flags);
> -
>         return SUCCESS;
>  }
> --
> 2.25.1
> 


Reviewed-by: Peter Wang <peter.wang@...iatek.com>