linux-kernel - Re: [PATCH] drm/rockchip: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2022996.jZfb76A358@diego>
Date: Fri, 16 May 2025 11:58:11 +0200
From: Heiko Stübner <heiko@...ech.de>
To: long.yunjian@....com.cn, hjc@...k-chips.com,
 Krzysztof Kozlowski <krzk@...nel.org>
Cc: andy.yan@...k-chips.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 fang.yumeng@....com.cn, mou.yi@....com.cn, xu.lifeng1@....com.cn,
 ouyang.maochun@....com.cn
Subject: Re: [PATCH] drm/rockchip: Use dev_err_probe() to simplify code

Am Donnerstag, 15. Mai 2025, 17:54:20 Mitteleuropäische Sommerzeit schrieb Krzysztof Kozlowski:
> On 15/05/2025 14:35, long.yunjian@....com.cn wrote:
> > From: Yumeng Fang <fang.yumeng@....com.cn>
> > 
> > In the probe path, dev_err() can be replaced with dev_err_probe()
> 
> That's not probe path. I am not sure if you really understand this code.

I think that is somewhat debateable.

dw_hdmi_rockchip_bind() is part of the rockchip-drm component device,
so part of its probe-path. Also I think just the presence of EPROBE_DEFER
which causes the device to re-try probing later is a nice indicator that the
code in question is _a_ probe path. (and usage of EPROBE_DEFER is an
established pattern to make that component device re-try probing later)

And the parse_dt function itself is part of that path too.


> > which will check if error code is -EPROBE_DEFER and prints the
> > error name. It also sets the defer probe reason which can be
> > checked later through debugfs.
> > 
> > Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> 
> Incomplete chain.

Yep, the patch needs a 2nd Signed-off-by line from
long.yunjian@....com.cn please.


Heiko