linux-kernel - Re: [PATCH v12 10/21] futex: Introduce futex_q_lockptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516121817.O0WRlIxQ@linutronix.de>
Date: Fri, 16 May 2025 14:18:17 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: André Almeida <andrealmeid@...lia.com>
Cc: Darren Hart <dvhart@...radead.org>, Davidlohr Bueso <dave@...olabs.net>,
	Ingo Molnar <mingo@...hat.com>, Juri Lelli <juri.lelli@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 10/21] futex: Introduce futex_q_lockptr_lock()

On 2025-05-08 16:06:28 [-0300], André Almeida wrote:
> > +/**
> > + * futex_hash_get - Get an additional reference for the local hash.
> > + * @hb:                    ptr to the private local hash.
> > + *
> > + * Obtain an additional reference for the already obtained hash bucket. The
> > + * caller must already own an reference.
> > + */
> 
> This comment should come with patch 6 (that creates the function) or patch
> 14 (that implements the function).

It is too late for that.

> > --- a/kernel/futex/futex.h
> > +++ b/kernel/futex/futex.h
> > @@ -183,6 +183,7 @@ struct futex_q {
> >   	union futex_key *requeue_pi_key;
> >   	u32 bitset;
> >   	atomic_t requeue_state;
> > +	bool drop_hb_ref;
> 
> This new member needs a comment:
> 
>  * @drop_hb_ref:	True if an extra reference was acquired by a pi operation,
> and needs an extra put()

This is done as of today.

Sebastian