linux-kernel - Re: [PATCH v12 05/21] futex: Create hb scopes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516122057.qAU9aPn3@linutronix.de>
Date: Fri, 16 May 2025 14:20:57 +0200
From: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To: André Almeida <andrealmeid@...lia.com>
Cc: linux-kernel@...r.kernel.org, Darren Hart <dvhart@...radead.org>,
	Davidlohr Bueso <dave@...olabs.net>, Ingo Molnar <mingo@...hat.com>,
	Juri Lelli <juri.lelli@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Valentin Schneider <vschneid@...hat.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH v12 05/21] futex: Create hb scopes

On 2025-05-06 20:45:06 [-0300], André Almeida wrote:
> > --- a/kernel/futex/core.c
> > +++ b/kernel/futex/core.c
> > @@ -957,50 +956,54 @@ static void exit_pi_state_list(struct task_struct *curr)
> >   		next = head->next;
> >   		pi_state = list_entry(next, struct futex_pi_state, list);
> >   		key = pi_state->key;
> > -		hb = futex_hash(&key);
> > +		if (1) {
> 
> Couldn't those explict scopes be achive without the if (1), just {}?

I don't see why not. I guess it looks nicer that way.

> > +			struct futex_hash_bucket *hb;
> 

Sebastian