linux-kernel - Re: [PATCH 2/7] Docu: PCI: Update pcim_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e80298be4bcb6b17f5b38302d6945306928c6b0.camel@mailbox.org>
Date: Fri, 16 May 2025 15:41:31 +0200
From: Philipp Stanner <phasta@...lbox.org>
To: Krzysztof Wilczyński <kw@...ux.com>, phasta@...nel.org
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jonathan Corbet
 <corbet@....net>, Bjorn Helgaas <bhelgaas@...gle.com>, Mark Brown
 <broonie@...nel.org>, David Lechner <dlechner@...libre.com>, Zijun Hu
 <quic_zijuhu@...cinc.com>, Yang Yingliang <yangyingliang@...wei.com>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org,  linux-pci@...r.kernel.org
Subject: Re: [PATCH 2/7] Docu: PCI: Update pcim_enable_device()

On Fri, 2025-05-16 at 22:28 +0900, Krzysztof Wilczyński wrote:
> Hello,
> 
> [...]
> > > > pcim_enable_device() is not related anymore to switching the
> > > > mode
> > > > of
> > > > operation of any functions. It merely sets up a devres callback
> > > > for
> > > > automatically disabling the PCI device on driver detach.
> > > > 
> > > > Adjust the function's documentation.
> > > 
> > > Is the "Docu" prefix in thew Subject aligned with the git history
> > > of
> > > this file?
> > > 
> > 
> > Seems its "Documentation: ". Can fix.
> 
> Has Andy been sending his review off-list?  Or something is broken on
> my
> side...

Nope, it's on-list. Andy's a veteran ;-)

https://lore.kernel.org/linux-pci/aCXnPHy5heHCKVd_@smile.fi.intel.com/


> 
> Philipp, if you have a v2 ready, then I would love to pull it, while
> we
> await for more reviews, just to get enough soak time and allow for
> the
> 0-day and KernelCI to run their usual tests, etc.
> 
> Thank you!

I don't have it ready, but should be trivial to do, since it's not
fundamental critcism. I'll do my best.

P.

> 
> 	Krzysztof