linux-kernel - Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab918cc3d5e26a6c38b3331172b60b6676bc32c5.camel@sipsolutions.net>
Date: Fri, 16 May 2025 15:56:07 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Markus Elfring <Markus.Elfring@....de>, vulab@...as.ac.cn, 
	linux-wireless@...r.kernel.org, Ajay Singh <ajay.kathat@...rochip.com>, 
 Claudiu Beznea <claudiu.beznea@...on.dev>, Kalle Valo <kvalo@...nel.org>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()

On Fri, 2025-05-16 at 15:50 +0200, Markus Elfring wrote:
> …
> > Add error handling for wilc_sdio_cmd52(). If wilc_sdio_cmd52() fails,
> > log an error message via dev_err().
> 
> Please avoid duplicate exception handling code.
> Can another jump target become nicer for this purpose?
> 

<form letter>
(stolen from Greg)

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.