linux-kernel - Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505180440.dyQDHWJJ-lkp@intel.com>
Date: Sun, 18 May 2025 04:35:03 +0800
From: kernel test robot <lkp@...el.com>
To: Wentao Liang <vulab@...as.ac.cn>, ajay.kathat@...rochip.com,
	claudiu.beznea@...on.dev, kvalo@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, Wentao Liang <vulab@...as.ac.cn>,
	stable@...r.kernel.org
Subject: Re: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()

Hi Wentao,

kernel test robot noticed the following build errors:

[auto build test ERROR on wireless-next/main]
[also build test ERROR on wireless/main linus/master v6.15-rc6 next-20250516]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Wentao-Liang/wifi-wilc1000-Add-error-handling-for-wilc_sdio_cmd52/20250516-163959
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20250516083842.903-1-vulab%40iscas.ac.cn
patch subject: [PATCH] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250518/202505180440.dyQDHWJJ-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250518/202505180440.dyQDHWJJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505180440.dyQDHWJJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/mmc/sdio_func.h:11,
                    from drivers/net/wireless/microchip/wilc1000/sdio.c:8:
   drivers/net/wireless/microchip/wilc1000/sdio.c: In function 'wilc_sdio_read_size':
>> drivers/net/wireless/microchip/wilc1000/sdio.c:792:32: error: 'struct sdio_func' has no member named 'devm'; did you mean 'dev'?
     792 |                 dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
         |                                ^~~~
   include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                         ^~~
   drivers/net/wireless/microchip/wilc1000/sdio.c:792:17: note: in expansion of macro 'dev_err'
     792 |                 dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
         |                 ^~~~~~~
   drivers/net/wireless/microchip/wilc1000/sdio.c:801:32: error: 'struct sdio_func' has no member named 'devm'; did you mean 'dev'?
     801 |                 dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
         |                                ^~~~
   include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                         ^~~
   drivers/net/wireless/microchip/wilc1000/sdio.c:801:17: note: in expansion of macro 'dev_err'
     801 |                 dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
         |                 ^~~~~~~


vim +792 drivers/net/wireless/microchip/wilc1000/sdio.c

   774	
   775	static int wilc_sdio_read_size(struct wilc *wilc, u32 *size)
   776	{
   777		u32 tmp;
   778		struct sdio_cmd52 cmd;
   779		struct sdio_func *func = dev_to_sdio_func(wilc->dev);
   780		int ret;
   781	
   782		/**
   783		 *      Read DMA count in words
   784		 **/
   785		cmd.read_write = 0;
   786		cmd.function = 0;
   787		cmd.raw = 0;
   788		cmd.address = WILC_SDIO_INTERRUPT_DATA_SZ_REG;
   789		cmd.data = 0;
   790		ret = wilc_sdio_cmd52(wilc, &cmd);
   791		if (ret) {
 > 792			dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
   793			return ret;
   794		}
   795		tmp = cmd.data;
   796	
   797		cmd.address = WILC_SDIO_INTERRUPT_DATA_SZ_REG + 1;
   798		cmd.data = 0;
   799		ret = wilc_sdio_cmd52(wilc, &cmd);
   800		if (ret) {
   801			dev_err(&func->devm, "Fail cmd 52, interrupt data register...\n");
   802			return ret;
   803		}
   804		tmp |= (cmd.data << 8);
   805	
   806		*size = tmp;
   807		return 0;
   808	}
   809	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki