linux-kernel - [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250516141722.13772-1-afd@ti.com>
Date: Fri, 16 May 2025 09:17:22 -0500
From: Andrew Davis <afd@...com>
To: Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>
CC: <linux-kernel@...r.kernel.org>, Andrew Davis <afd@...com>
Subject: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ

If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
based on the above two symbols respectively. This makes it very easy
to end up with "circular dependencies".

Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
use of them. This is almost equivalent to before but makes it less
likely to end up with false circular dependency detections.

Signed-off-by: Andrew Davis <afd@...com>
---

Sending as RFC as I haven't tested all the possible permutations
on config options right now to make sure this causes no changes,
but wanted to suggest this as a possible solution to the circular
dependency described here[0].

[0] https://www.spinics.net/lists/kernel/msg5686254.html

 drivers/base/regmap/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
index b1affac70d5dc..ffb2ef4882981 100644
--- a/drivers/base/regmap/Kconfig
+++ b/drivers/base/regmap/Kconfig
@@ -6,8 +6,6 @@
 config REGMAP
 	bool
 	default y if (REGMAP_I2C || REGMAP_SPI || REGMAP_SPMI || REGMAP_W1 || REGMAP_AC97 || REGMAP_MMIO || REGMAP_IRQ || REGMAP_SOUNDWIRE || REGMAP_SOUNDWIRE_MBQ || REGMAP_SCCB || REGMAP_I3C || REGMAP_SPI_AVMM || REGMAP_MDIO || REGMAP_FSI)
-	select IRQ_DOMAIN if REGMAP_IRQ
-	select MDIO_BUS if REGMAP_MDIO
 	help
 	  Enable support for the Register Map (regmap) access API.

@@ -58,12 +56,14 @@ config REGMAP_W1

 config REGMAP_MDIO
 	tristate
+	select MDIO_BUS

 config REGMAP_MMIO
 	tristate

 config REGMAP_IRQ
 	bool
+	select IRQ_DOMAIN

 config REGMAP_RAM
 	tristate
-- 
2.39.2