linux-kernel - Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <efdfa6fe-2d9f-4c68-93db-08df05af6922@linaro.org>
Date: Sun, 18 May 2025 14:25:24 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Andrew Davis <afd@...com>, Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ

On 16/05/2025 16:17, Andrew Davis wrote:
> If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
> This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
> based on the above two symbols respectively. This makes it very easy
> to end up with "circular dependencies".
> 
> Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
> use of them. This is almost equivalent to before but makes it less
> likely to end up with false circular dependency detections.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
> 
> Sending as RFC as I haven't tested all the possible permutations
> on config options right now to make sure this causes no changes,
> but wanted to suggest this as a possible solution to the circular
> dependency described here[0].


Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Closes: https://lore.kernel.org/r/bfe991fa-f54c-4d58-b2e0-34c4e4eb48f4@linaro.org/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Looks ok and seems to solve issues I saw.

This is a potential dependency for a mux patch I want to send to Greg
for upcoming merge window, so it would be great if this was marked as fixes
and got to current RC. Or optionally I could take it with mentioned
mux patch:
https://lore.kernel.org/all/20250515140555.325601-2-krzysztof.kozlowski@linaro.org/


Best regards,
Krzysztof