linux-kernel - Re: [PATCH] firmware: arm_scmi: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb0b9f89-8c34-4d30-87bd-c4e631f5b1b7@wanadoo.fr>
Date: Fri, 16 May 2025 17:25:59 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: long.yunjian@....com.cn, sudeep.holla@....com
Cc: cristian.marussi@....com, peng.fan@....com, justin.chen@...adcom.com,
 florian.fainelli@...adcom.com, arm-scmi@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 fang.yumeng@....com.cn, mou.yi@....com.cn, ouyang.maochun@....com.cn,
 xu.lifeng1@....com.cn
Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code

Le 15/05/2025 à 14:38, long.yunjian@....com.cn a écrit :
> From: Yumeng Fang <fang.yumeng@....com.cn>
> 
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
> 
> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> ---
>   drivers/firmware/arm_scmi/transports/mailbox.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmware/arm_scmi/transports/mailbox.c
> index bd041c99b92b..816e79537935 100644
> --- a/drivers/firmware/arm_scmi/transports/mailbox.c
> +++ b/drivers/firmware/arm_scmi/transports/mailbox.c
> @@ -13,6 +13,7 @@
>   #include <linux/of_address.h>
>   #include <linux/platform_device.h>
>   #include <linux/slab.h>
> +#include <linux/dev_printk.h>
> 

includes are (mostly) alphabetically ordered right-now.
So, It would be better to keep this logic, IMHO.

CJ