| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <2025052115591093831MdOvruWdMiauIhA8-r3@zte.com.cn>
Date: Wed, 21 May 2025 15:59:10 +0800 (CST)
From: <long.yunjian@....com.cn>
To: <christophe.jaillet@...adoo.fr>, <sudeep.holla@....com>,
<dan.carpenter@...aro.org>
Cc: <cristian.marussi@....com>, <peng.fan@....com>, <justin.chen@...adcom.com>,
<florian.fainelli@...adcom.com>, <arm-scmi@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
<fang.yumeng@....com.cn>, <mou.yi@....com.cn>,
<ouyang.maochun@....com.cn>, <xu.lifeng1@....com.cn>
Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code
> Dan Carpenter:
> It's probably better to get rid of the "ret = PTR_ERR(smbox->chan);"
> assignment as well. Then it's a one liner:
>
> if (IS_ERR(smbox->chan))
> return dev_err_probe(cdev, PTR_ERR(smbox->chan),
> "failed to request SCMI %s mailbox\n", desc);
>
> Christophe Jaillet:
>> #include <linux/of_address.h>
>> #include <linux/platform_device.h>
>> #include <linux/slab.h>
>> +#include <linux/dev_printk.h>
>
> includes are (mostly) alphabetically ordered right-now.
> So, It would be better to keep this logic, IMHO.
Dear Dan Carpenter and Christophe Jaillet,
Thank you both for your invaluable suggestions!
I have thoroughly revised the code based on your feedback.
I will send the PATCH V2 and look forward to your further review.
Best regards,
Fang Yumeng
Original
From: christophe.jaillet <christophe.jaillet@...adoo.fr>
To: Long Yunjian10171699;sudeep.holla <sudeep.holla@....com>;
Cc: cristian.marussi <cristian.marussi@....com>;peng.fan <peng.fan@....com>;justin.chen <justin.chen@...adcom.com>;florian.fainelli <florian.fainelli@...adcom.com>;arm-scmi <arm-scmi@...r.kernel.org>;linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>;linux-kernel <linux-kernel@...r.kernel.org>;Fang Yumeng00336438;Mou Yi10205508;Ouyang Maochun10090504;Xu Lifeng10013465;
Date: 2025/05/16 23:26
Subject: Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code
Le 15/05/2025 à 14:38, long.yunjian@....com.cn a écrit :
> From: Yumeng Fang <fang.yumeng@....com.cn>
>
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn>
> ---
> drivers/firmware/arm_scmi/transports/mailbox.c | 17 +++++++----------
> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmware/arm_scmi/transports/mailbox.c
> index bd041c99b92b..816e79537935 100644
> --- a/drivers/firmware/arm_scmi/transports/mailbox.c
> +++ b/drivers/firmware/arm_scmi/transports/mailbox.c
> @@ -13,6 +13,7 @@
> #include <linux/of_address.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> +#include <linux/dev_printk.h>
>
includes are (mostly) alphabetically ordered right-now.
So, It would be better to keep this logic, IMHO.
CJ
<div class="zcontentRow"><p>> Dan Carpenter:</p><p>> It's probably better to get rid of the "ret = PTR_ERR(smbox->chan);"</p><p>> assignment as well. Then it's a one liner:</p><p>></p><p>> if (IS_ERR(smbox->chan))</p><p>> return dev_err_probe(cdev, PTR_ERR(smbox->chan),</p><p>> "failed to request SCMI %s mailbox\n", desc);</p><p>></p><p>> Christophe Jaillet:</p><p>>> #include <linux/of_address.h></p><p>>> #include <linux/platform_device.h></p><p>>> #include <linux/slab.h></p><p>>> +#include <linux/dev_printk.h></p><p>></p><p>> includes are (mostly) alphabetically ordered right-now.</p><p>> So, It would be better to keep this logic, IMHO.</p><p><br></p><p><br></p><p>Dear Dan Carpenter and Christophe Jaillet,</p><p>Thank you both for your invaluable suggestions! </p><p>I have thoroughly revised the code based on your feedback.</p><p>I will send the PATCH V2 and look forward to your further review.</p><p><br></p><p><br></p><p>Best regards,</p><p>Fang Yumeng</p><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;">Original</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong>From: </strong><span class="zreadUserName">christophe.jaillet <christophe.jaillet@...adoo.fr></span></div><div><strong>To: </strong><span class="zreadUserName" style="display: inline;">Long Yunjian10171699;</span><span class="zreadUserName" style="display: inline;">sudeep.holla <sudeep.holla@....com>;</span></div><div><strong>Cc: </strong><span class="zreadUserName" style="display: inline;">cristian.marussi <cristian.marussi@....com>;</span><span class="zreadUserName" style="display: inline;">peng.fan <peng.fan@....com>;</span><span class="zreadUserName" style="display: inline;">justin.chen <justin.chen@...adcom.com>;</span><span class="zreadUserName" style="display: inline;">florian.fainelli <florian.fainelli@...adcom.com>;</span><span class="zreadUserName" style="display: inline;">arm-scmi <arm-scmi@...r.kernel.org>;</span><span class="zreadUserName" style="display: inline;">linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>;</span><span class="zreadUserName" style="display: inline;">linux-kernel <linux-kernel@...r.kernel.org>;</span><span class="zreadUserName" style="display: inline;">Fang Yumeng00336438;</span><span class="zreadUserName" style="display: inline;">Mou Yi10205508;</span><span class="zreadUserName" style="display: inline;">Ouyang Maochun10090504;</span><span class="zreadUserName" style="display: inline;">Xu Lifeng10013465;</span></div><div><strong>Date: </strong><span class="">2025/05/16 23:26</span></div><div><strong>Subject: </strong><span class="zreadTitle"><strong>Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code</strong></span></div></div><div class="zhistoryContent">Le 15/05/2025 à 14:38, long.yunjian@....com.cn a écrit :<br>> From: Yumeng Fang <fang.yumeng@....com.cn> <br>> <br>> In the probe path, dev_err() can be replaced with dev_err_probe()<br>> which will check if error code is -EPROBE_DEFER and prints the<br>> error name. It also sets the defer probe reason which can be<br>> checked later through debugfs.<br>> <br>> Signed-off-by: Yumeng Fang <fang.yumeng@....com.cn> <br>> ---<br>> drivers/firmware/arm_scmi/transports/mailbox.c | 17 +++++++----------<br>> 1 file changed, 7 insertions(+), 10 deletions(-)<br>> <br>> diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmware/arm_scmi/transports/mailbox.c<br>> index bd041c99b92b..816e79537935 100644<br>> --- a/drivers/firmware/arm_scmi/transports/mailbox.c<br>> +++ b/drivers/firmware/arm_scmi/transports/mailbox.c<br>> @@ -13,6 +13,7 @@<br>> #include <linux/of_address.h> <br>> #include <linux/platform_device.h> <br>> #include <linux/slab.h> <br>> +#include <linux/dev_printk.h> <br>> <br> <br>includes are (mostly) alphabetically ordered right-now.<br>So, It would be better to keep this logic, IMHO.<br> <br>CJ</div></div></div></div><p><br></p></div>
Powered by blists - more mailing lists