linux-kernel - Re: [PATCH V3 11/16] arc/perf: Remove driver-specific throttle support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3fa9e90-a94b-47f7-b911-ed7c97fd1d6f@kernel.org>
Date: Sun, 18 May 2025 14:58:05 -0700
From: Vineet Gupta <vgupta@...nel.org>
To: kan.liang@...ux.intel.com, peterz@...radead.org, mingo@...hat.com,
 namhyung@...nel.org, irogers@...gle.com, mark.rutland@....com,
 linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org
Cc: eranian@...gle.com, ctshao@...gle.com, tmricht@...ux.ibm.com,
 leo.yan@....com, linux-snps-arc@...ts.infradead.org
Subject: Re: [PATCH V3 11/16] arc/perf: Remove driver-specific throttle
 support



On 5/16/25 11:28, kan.liang@...ux.intel.com wrote:
> From: Kan Liang <kan.liang@...ux.intel.com>
>
> The throttle support has been added in the generic code. Remove
> the driver-specific throttle support.
>
> Besides the throttle, perf_event_overflow may return true because of
> event_limit. It already does an inatomic event disable. The pmu->stop
> is not required either.
>
> Signed-off-by: Kan Liang <kan.liang@...ux.intel.com>
> Cc: Vineet Gupta <vgupta@...rnel.org>
> Cc: linux-snps-arc@...ts.infradead.org
Acked-by: Vineet Gupta <vgupta@...nel.org>

Please let me know if you wane to take it via ARC tree.

Thx,
-Vineet

> ---
>  arch/arc/kernel/perf_event.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arc/kernel/perf_event.c b/arch/arc/kernel/perf_event.c
> index 6e5a651cd75c..ed6d4f0cd621 100644
> --- a/arch/arc/kernel/perf_event.c
> +++ b/arch/arc/kernel/perf_event.c
> @@ -599,10 +599,8 @@ static irqreturn_t arc_pmu_intr(int irq, void *dev)
>  
>  		arc_perf_event_update(event, &event->hw, event->hw.idx);
>  		perf_sample_data_init(&data, 0, hwc->last_period);
> -		if (arc_pmu_event_set_period(event)) {
> -			if (perf_event_overflow(event, &data, regs))
> -				arc_pmu_stop(event, 0);
> -		}
> +		if (arc_pmu_event_set_period(event))
> +			perf_event_overflow(event, &data, regs);
>  
>  		active_ints &= ~BIT(idx);
>  	} while (active_ints);