linux-kernel - Re: [PATCH] HID: lenovo: Unbreak USB/BT keyboards on non-ACPI platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250518220305.GB2575813@robin.jannau.net>
Date: Mon, 19 May 2025 00:03:05 +0200
From: Janne Grunau <j@...nau.net>
To: Armin Wolf <W_Armin@....de>
Cc: Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>,
	Vishnu Sankar <vishnuocv@...il.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] HID: lenovo: Unbreak USB/BT keyboards on non-ACPI
 platforms

Hej,

On Sun, May 18, 2025 at 07:46:12PM +0200, Armin Wolf wrote:
> Am 18.05.25 um 11:43 schrieb Janne Grunau:
> 
> >>   
> >>   static void __exit platform_profile_exit(void)
> >>   {
> >> -	sysfs_remove_group(acpi_kobj, &platform_profile_group);
> >> +	if (acpi_kobj)
> >> +		sysfs_remove_group(acpi_kobj, &platform_profile_group);
> >> +
> >>   	class_unregister(&platform_profile_class);
> >>   }
> >>   module_init(platform_profile_init);
> > thanks, patch works on the affected system and the HID device for the
> > Lenovo keyboard probes successfully. We still need to stub
> > platform_profile_cycle() to get rid of the ACPI Kconfig dependency. I'll
> > send that out separately.
> >
> > Reviewed-by: Janne Grunau <j@...nau.net>
> > Tested-by: Janne Grunau <j@...nau.net>
> >
> Alright, i will send this patch to the ACPI mailing list ASAP. Please keep in mind
> that merely stubbing out the affected functions is not enough, as the platform profile code
> needs to be moved out of drivers/acpi/ as well.

Thanks. I will go with patch which #ifdefs the platform_profile_cycle()
call out. It is only used for a special detachable tablet keyboard which
is ACPI enabled device anyway. So it will be hid-lenovo local change.

Janne