linux-kernel - RE: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SL2P216MB1246B1DA93D85C1536476D74FB9CA@SL2P216MB1246.KORP216.PROD.OUTLOOK.COM>
Date: Mon, 19 May 2025 05:08:23 +0000
From: Nas Chung <nas.chung@...psnmedia.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: "mchehab@...nel.org" <mchehab@...nel.org>, "hverkuil@...all.nl"
	<hverkuil@...all.nl>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "linux-media@...r.kernel.org"
	<linux-media@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-imx@....com" <linux-imx@....com>,
	"marex@...x.de" <marex@...x.de>, jackson.lee <jackson.lee@...psnmedia.com>,
	lafley.kim <lafley.kim@...psnmedia.com>
Subject: RE: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec
 device

Hi, Krzysztof.

>-----Original Message-----
>From: Krzysztof Kozlowski <krzk@...nel.org>
>Sent: Friday, May 16, 2025 9:56 PM
>To: Nas Chung <nas.chung@...psnmedia.com>
>Cc: mchehab@...nel.org; hverkuil@...all.nl; sebastian.fricke@...labora.com;
>robh@...nel.org; krzk+dt@...nel.org; conor+dt@...nel.org; linux-
>media@...r.kernel.org; devicetree@...r.kernel.org; linux-
>kernel@...r.kernel.org; linux-imx@....com; marex@...x.de; jackson.lee
><jackson.lee@...psnmedia.com>; lafley.kim <lafley.kim@...psnmedia.com>
>Subject: Re: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec
>device
>
>On 13/05/2025 09:39, Nas Chung wrote:
>>>
>>> All of above are wrong for the SoC...
>>>
>>>>
>>>>         #include <dt-bindings/interrupt-controller/arm-gic.h>
>>>>         #include <dt-bindings/clock/nxp,imx95-clock.h>
>>>>
>>>>         soc {
>>>>           #address-cells = <2>;
>>>>           #size-cells = <2>;
>>>>
>>>>           vpu: video-codec {
>>>>             compatible = "nxp,imx95-vpu", "cnm,wave633c";
>>>
>>> What does this device represent? It is not "ctrl", because you made ctrl
>>> separate device node. Your binding description suggests that is the VPU
>>> control region.
>>
>> My intention was to represent the MMIO VPU device, which includes
>> both the core and control nodes.
>
>Then what is the VPU device if not CTRL? What is the CTRL device?

The VPU device represents the entire VPU hardware block,
which includes 1 CTRL component(node) and 4 CORE components(nodes).

The CTRL device represents the VCPU, a 32-bit processor embedded within the
VPU hardware block. This VCPU is responsible for executing the VPU firmware.
The CTRL device is in charge of tasks such as firmware booting, power management
(sleep and wakeup command), and managing memory regions that are exclusively
accessed by the firmware.

The CORE device represents the Video Coding Engine, which is the hardware core
responsible for performing the actual video encoding and decoding operations.

I intended to represent the VPU device as a single grouping or parent node to
reflect that CTRL and CORE are integrated in a VPU hardware block.

Thanks.
Nas.

>
>
>Best regards,
>Krzysztof