linux-kernel - Re: [PATCH v2 4/4] LoongArch: dts: Add initial devicetree for CTCISZ Forever Pi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpQs4+GiZpLfSHx9k_QfWjXtyrNS4LS4dOuCKLbS-F8OhpoWg@mail.gmail.com>
Date: Mon, 19 May 2025 15:58:29 +0800
From: Binbin Zhou <zhoubb.aaron@...il.com>
To: Yao Zi <ziyao@...root.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Huacai Chen <chenhuacai@...nel.org>, 
	WANG Xuerui <kernel@...0n.name>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Heiko Stuebner <heiko@...ech.de>, Junhao Xie <bigfoot@...ssfun.cn>, 
	Rafał Miłecki <rafal@...ecki.pl>, 
	Aradhya Bhatia <a-bhatia1@...com>, Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
	Binbin Zhou <zhoubinbin@...ngson.cn>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, 
	Mingcong Bai <jeffbai@...c.io>, Kexy Biscuit <kexybiscuit@...c.io>
Subject: Re: [PATCH v2 4/4] LoongArch: dts: Add initial devicetree for CTCISZ
 Forever Pi

Hi Yao:

On Sun, May 18, 2025 at 4:05 PM Yao Zi <ziyao@...root.org> wrote:
>
> Enable UART0 as it's the boot UART used by firmware.
>
> Signed-off-by: Yao Zi <ziyao@...root.org>
> ---
>  arch/loongarch/boot/dts/Makefile              |  1 +
>  .../boot/dts/ls2k0300-ctcisz-forever-pi.dts   | 45 +++++++++++++++++++

A minor suggestion:
As we can see, the existing dtsi/dts files are prefixed with
“loongosn-2k”, would it be possible to keep the filenames consistent?

>  2 files changed, 46 insertions(+)
>  create mode 100644 arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dts
>
> diff --git a/arch/loongarch/boot/dts/Makefile b/arch/loongarch/boot/dts/Makefile
> index 15d5e14fe418..9fff9e8be3de 100644
> --- a/arch/loongarch/boot/dts/Makefile
> +++ b/arch/loongarch/boot/dts/Makefile
> @@ -1,3 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>
>  dtb-y = loongson-2k0500-ref.dtb loongson-2k1000-ref.dtb loongson-2k2000-ref.dtb
> +dtb-y += ls2k0300-ctcisz-forever-pi.dtb
> diff --git a/arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dts b/arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dts
> new file mode 100644
> index 000000000000..a033c086461f
> --- /dev/null
> +++ b/arch/loongarch/boot/dts/ls2k0300-ctcisz-forever-pi.dts
> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (C) 2025 Yao Zi <ziyao@...root.org>
> + */
> +
> +/dts-v1/;
> +
> +#include "loongson-2k0300.dtsi"
> +
> +/ {
> +       compatible = "ctcisz,forever-pi", "loongson,ls2k0300";
> +       model = "CTCISZ Forever Pi";
> +
> +       aliases {
> +               serial0 = &uart0;
> +       };
> +
> +       chosen {
> +               stdout-path = "serial0:115200n8";
> +       };
> +
> +       memory@...000 {
> +               device_type = "memory";
> +               reg = <0 0x00200000 0 0x0ee00000>,
> +                     <0 0x90000000 0 0x10000000>;
> +       };
> +
> +       reserved-memory {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               ranges;
> +
> +               linux,cma {
> +                       compatible = "shared-dma-pool";
> +                       reusable;
> +                       size = <0 0x02000000>;
> +                       linux,cma-default;
> +               };
> +       };
> +};
> +
> +&uart0 {
> +       clock-frequency = <100000000>;
> +       status = "okay";
> +};
> --
> 2.49.0
>
>

-- 
Thanks.
Binbin