linux-kernel - Re: [PATCH 11/16] iio: mcp3564: Fix type incompatibility with non-macro find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bf6a6e3fec803c31adb8b227bd4ca95907ebe30.camel@microchip.com>
Date: Mon, 19 May 2025 08:09:20 +0000
From: <Marius.Cristea@...rochip.com>
To: <linux-leds@...r.kernel.org>, <asoponar@...adin.ro>,
	<linux-hwmon@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-iio@...r.kernel.org>, <linux-watchdog@...r.kernel.org>
CC: <linux@...ck-us.net>, <jdelvare@...e.com>, <wim@...ux-watchdog.org>,
	<lee@...nel.org>, <angelogioacchino.delregno@...labora.com>,
	<aardelean@...libre.com>, <jic23@...nel.org>, <pavel@....cz>,
	<tobias.schaffner@...mens.com>, <baocheng.su@...mens.com>,
	<matthias.bgg@...il.com>, <contact@...y.one>,
	<benedikt.niedermayr@...mens.com>
Subject: Re: [PATCH 11/16] iio: mcp3564: Fix type incompatibility with
 non-macro find_closest

On Thu, 2025-05-15 at 11:13 +0300, Alexandru Soponar wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you
> know the content is safe
> 
> The mcp3564_oversampling_avail array was previously declared as
> unsigned
> int but used with find_closest(). With find_closest() now implemented
> as
> a function taking signed int parameters instead of a macro,  passing
> unsigned arrays causes type incompatibility errors. This patch
> changes the
> arrays type from unsigned int to int to ensure compatibility with the
> function signature and prevent compilation errors.
> 
> Signed-off-by: Alexandru Soponar <asoponar@...adin.ro>

Hi Alexandru,

	Thank you very much for the patch. The patch is OK.

Reviewed-by: Marius Cristea <marius.cristea@...rochip.com>


Thanks,
Marius 


> ---
>  drivers/iio/adc/mcp3564.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mcp3564.c b/drivers/iio/adc/mcp3564.c
> index a68f1cd6883e..01efc77f710a 100644
> --- a/drivers/iio/adc/mcp3564.c
> +++ b/drivers/iio/adc/mcp3564.c
> @@ -253,7 +253,7 @@ enum mcp3564_oversampling {
>         MCP3564_OVERSAMPLING_RATIO_98304
>  };
> 
> -static const unsigned int mcp3564_oversampling_avail[] = {
> +static const int mcp3564_oversampling_avail[] = {
>         [MCP3564_OVERSAMPLING_RATIO_32] = 32,
>         [MCP3564_OVERSAMPLING_RATIO_64] = 64,
>         [MCP3564_OVERSAMPLING_RATIO_128] = 128,
> --
> 2.49.0
>