linux-kernel - Re: [V1 2/2] drivers soc: add support for ST stm32mp13xx family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b684c13f-4686-4ef0-912c-332b8a5f9b66@kernel.org>
Date: Tue, 20 May 2025 11:15:04 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rodolfo Giometti <giometti@...eenne.com>
Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Eric Fourmont <eric.fourmont-ext@...com>,
 Yann GAUTIER <yann.gautier@...s.st.com>, linux-kernel@...r.kernel.org
Subject: Re: [V1 2/2] drivers soc: add support for ST stm32mp13xx family

On 20/05/2025 11:01, Rodolfo Giometti wrote:
> On 19/05/25 20:34, Krzysztof Kozlowski wrote:
>> On 19/05/2025 15:08, Rodolfo Giometti wrote:
> 
> [snip]
> 
>>> +
>>> +static int __init stm32mp13_soc_get_idc(u32 *idc)
>>> +{
>>> +	struct device_node *np;
>>> +	void __iomem *regs;
>>> +	static const struct of_device_id devids[] = {
>>> +		{ .compatible = "st,stm32mp157-syscfg" },
>>
>> No, don't add compatibles for other devices into the driver functions.
>> Use standard methods for binding, like every driver does.
> 
> I need to access a region assigned to another driver very early on boot, and 
> this is the only way I've found to solve the problem. Can you please give me an 

Why do you need to access it very early? The code did not suggest that.

> example of these standard binding methods?

Driver should bind just like all regular drivers, so other socinfo
drivers as well. If you need other nodes, then use phandles for a syscon
- that's the standard method.

Best regards,
Krzysztof