linux-kernel - Re: [PATCH 0/2] Input: adp5588-keys Please correct and add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d3e9a97e0c1f4d5a5eeaee133b5980a0a065aac.camel@gmail.com>
Date: Tue, 20 May 2025 12:15:12 +0100
From: Nuno Sá <noname.nuno@...il.com>
To: Denis Arefev <arefev@...mel.ru>
Cc: dmitry.torokhov@...il.com, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org, 
	michael.hennerich@...log.com
Subject: Re: [PATCH 0/2] Input: adp5588-keys Please correct and add

On Tue, 2025-05-20 at 14:12 +0300, Denis Arefev wrote:
> > On Fri, 2025-05-16 at 16:43 +0300, Denis Arefev wrote:
> > > 1. Add check on return code
> > > 2. Prevent buffer overflow
> > > 
> > > Denis Arefev (2):
> > >   Input: adp5588-keys Add check on return code
> > >   Input: adp5588-keys Prevent buffer overflow
> > > 
> > >  drivers/input/keyboard/adp5588-keys.c | 18 ++++++++++++++----
> > >  1 file changed, 14 insertions(+), 4 deletions(-)
> > 
> > Hi,
> > 
> > Thanks for the patch. However, not sure if this is really worth it... This
> > is
> > driver is in the process of being removed:
> > 
> > https://lore.kernel.org/linux-input/04b8a6d68fdc0c0eadf69fbbc6a130ecc6c49360.camel@gmail.com/T/#mad1980e9652161a6a2e36c2aeeb97f900c6e9fc2
> > 
> > Unless we want somehow to backport these patches?
> > 
> > - Nuno Sá
> 
> Hi Nuno.
> 
> It'd be great if the fix patches are applied and then directed
> to stable kernels before the code is dropped from upstream.
> I've sent v3 with relevant stable tags included. Thanks.

Not up to me to decide that :)

- Nuno Sá