linux-kernel - Re: [PATCH] net: hns3: Add error handling for VLAN filter hardwareconfiguration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <e35be8e7-9956-46fb-9a8f-d09506465d61@huawei.com>
Date: Wed, 21 May 2025 10:43:42 +0800
From: Jijie Shao <shaojijie@...wei.com>
To: Wentao Liang <vulab@...as.ac.cn>, "salil.mehta@...wei.com"
	<salil.mehta@...wei.com>, "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: <shaojijie@...wei.com>, "horms@...nel.org" <horms@...nel.org>,
	"lanhao@...wei.com" <lanhao@...wei.com>, "wangpeiyang1@...wei.com"
	<wangpeiyang1@...wei.com>, "rosenp@...il.com" <rosenp@...il.com>,
	"liuyonglong@...wei.com" <liuyonglong@...wei.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: hns3: Add error handling for VLAN filter
 hardwareconfiguration


on 2025/5/20 9:14, Wentao Liang wrote:
>
> > Are there any real functional problems?
>
> > Would you please tell me your test cases? I'm going to try to reproduce the problem.
>
> Hi,
>
> I found this problem by static analysis and manual auditing. I believe 
> there should be add a check just like the other call of 
> hclge_set_vlan_filter_hw(). If the check is useless, could you please 
> tell me the detailed reason.
>
Hi Wentao,
  
Thanks for your reply.

I checked the code, and found that the purpose of all two places called hclge_rm_vport_vlan_table() now is just to update the vlan list,
never do clear the vlan entry in hardware. So I prefer to remove the parameter 'is_write_tbl' from hclge_rm_vport_vlan_table(),
and remove the hclge_set_vlan_filter_hw() calling in it.

Thanks,
Jijie Shao

> Thanks,
>
> Wentao Liang.
>