linux-kernel - Re: [PATCH v2 1/3] soc: qcom: qcom_stats: Add support to read DDR statistic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202505220739.yseb9RQm-lkp@intel.com>
Date: Thu, 22 May 2025 07:40:28 +0800
From: kernel test robot <lkp@...el.com>
To: Maulik Shah <maulik.shah@....qualcomm.com>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konradybcio@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Marijn Suijten <marijn.suijten@...ainline.org>,
	Doug Anderson <dianders@...omium.org>,
	Maulik Shah <maulik.shah@....qualcomm.com>
Subject: Re: [PATCH v2 1/3] soc: qcom: qcom_stats: Add support to read DDR
 statistic

Hi Maulik,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 393d0c54cae31317deaa9043320c5fd9454deabc]

url:    https://github.com/intel-lab-lkp/linux/commits/Maulik-Shah/soc-qcom-qcom_stats-Add-support-to-read-DDR-statistic/20250521-163434
base:   393d0c54cae31317deaa9043320c5fd9454deabc
patch link:    https://lore.kernel.org/r/20250521-ddr_stats_-v2-1-2c54ea4fc071%40oss.qualcomm.com
patch subject: [PATCH v2 1/3] soc: qcom: qcom_stats: Add support to read DDR statistic
config: arc-randconfig-001-20250522 (https://download.01.org/0day-ci/archive/20250522/202505220739.yseb9RQm-lkp@intel.com/config)
compiler: arc-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505220739.yseb9RQm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505220739.yseb9RQm-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/soc/qcom/qcom_stats.c: In function 'qcom_ddr_stats_print':
>> drivers/soc/qcom/qcom_stats.c:172:53: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
     172 |                 seq_printf(s, "DDR LPM Stat Name:0x%x\tcount:%u\tDuration (ticks):%llu\n",
         |                                                    ~^
         |                                                     |
         |                                                     unsigned int
         |                                                    %lx
>> drivers/soc/qcom/qcom_stats.c:180:42: warning: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=]
     180 |                 seq_printf(s, "DDR Freq %uMhz:\tCP IDX:%u\tcount:%u\tDuration (ticks):%llu\n",
         |                                         ~^
         |                                          |
         |                                          unsigned int
         |                                         %lu


vim +172 drivers/soc/qcom/qcom_stats.c

   144	
   145	static void qcom_ddr_stats_print(struct seq_file *s, struct ddr_stats_entry *data)
   146	{
   147		u32 cp_idx;
   148	
   149		/*
   150		 * DDR statistic have two different types of details encoded.
   151		 * (1) DDR LPM Stats
   152		 * (2) DDR Frequency Stats
   153		 *
   154		 * The name field have details like which type of DDR stat (bits 8:15)
   155		 * along with other details as explained below
   156		 *
   157		 * In case of DDR LPM stat, name field will be encoded as,
   158		 * Bits	 -  Meaning
   159		 * 0:7	 -  DDR LPM name, can be of 0xd4, 0xd3, 0x11 and 0xd0.
   160		 * 8:15	 -  0x0 (indicates its a LPM stat)
   161		 * 16:31 -  Unused
   162		 *
   163		 * In case of DDR FREQ stats, name field will be encoded as,
   164		 * Bits  -  Meaning
   165		 * 0:4   -  DDR Clock plan index (CP IDX)
   166		 * 5:7   -  Unused
   167		 * 8:15  -  0x1 (indicates its Freq stat)
   168		 * 16:31 -  Frequency value in Mhz
   169		 */
   170		switch (DDR_STATS_TYPE(data->name)) {
   171		case 0:
 > 172			seq_printf(s, "DDR LPM Stat Name:0x%x\tcount:%u\tDuration (ticks):%llu\n",
   173				   DDR_STATS_LPM_NAME(data->name), data->count, data->duration);
   174			break;
   175		case 1:
   176			if (!data->count || !DDR_STATS_FREQ(data->name))
   177				return;
   178	
   179			cp_idx = DDR_STATS_CP_IDX(data->name);
 > 180			seq_printf(s, "DDR Freq %uMhz:\tCP IDX:%u\tcount:%u\tDuration (ticks):%llu\n",
   181				   DDR_STATS_FREQ(data->name), cp_idx, data->count, data->duration);
   182			break;
   183		}
   184	}
   185	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki