linux-kernel - RE: [Intel-wired-lan] [PATCH net-next 1/3] net: ASSERT_RTNL remove netif_set_real_num_{rx, tx}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB58660E85F76E4A347197C768E59EA@SJ0PR11MB5866.namprd11.prod.outlook.com>
Date: Wed, 21 May 2025 05:14:11 +0000
From: "Loktionov, Aleksandr" <aleksandr.loktionov@...el.com>
To: Stanislav Fomichev <stfomichev@...il.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "skalluru@...vell.com"
	<skalluru@...vell.com>, "manishc@...vell.com" <manishc@...vell.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "michael.chan@...adcom.com"
	<michael.chan@...adcom.com>, "pavan.chebbi@...adcom.com"
	<pavan.chebbi@...adcom.com>, "ajit.khaparde@...adcom.com"
	<ajit.khaparde@...adcom.com>, "sriharsha.basavapatna@...adcom.com"
	<sriharsha.basavapatna@...adcom.com>, "somnath.kotur@...adcom.com"
	<somnath.kotur@...adcom.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "tariqt@...dia.com" <tariqt@...dia.com>,
	"saeedm@...dia.com" <saeedm@...dia.com>, "louis.peens@...igine.com"
	<louis.peens@...igine.com>, "shshaikh@...vell.com" <shshaikh@...vell.com>,
	"GR-Linux-NIC-Dev@...vell.com" <GR-Linux-NIC-Dev@...vell.com>,
	"ecree.xilinx@...il.com" <ecree.xilinx@...il.com>, "horms@...nel.org"
	<horms@...nel.org>, "dsahern@...nel.org" <dsahern@...nel.org>,
	"ruanjinjie@...wei.com" <ruanjinjie@...wei.com>, "mheib@...hat.com"
	<mheib@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "oss-drivers@...igine.com"
	<oss-drivers@...igine.com>, "linux-net-drivers@....com"
	<linux-net-drivers@....com>, "leon@...nel.org" <leon@...nel.org>
Subject: RE: [Intel-wired-lan] [PATCH net-next 1/3] net: ASSERT_RTNL remove
 netif_set_real_num_{rx, tx}_queues



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf
> Of Stanislav Fomichev
> Sent: Tuesday, May 20, 2025 10:36 PM
> To: netdev@...r.kernel.org
> Cc: davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; skalluru@...vell.com; manishc@...vell.com;
> andrew+netdev@...n.ch; michael.chan@...adcom.com;
> pavan.chebbi@...adcom.com; ajit.khaparde@...adcom.com;
> sriharsha.basavapatna@...adcom.com; somnath.kotur@...adcom.com;
> Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>; tariqt@...dia.com; saeedm@...dia.com;
> louis.peens@...igine.com; shshaikh@...vell.com; GR-Linux-NIC-
> Dev@...vell.com; ecree.xilinx@...il.com; horms@...nel.org;
> dsahern@...nel.org; ruanjinjie@...wei.com; mheib@...hat.com;
> stfomichev@...il.com; linux-kernel@...r.kernel.org; intel-wired-
> lan@...ts.osuosl.org; linux-rdma@...r.kernel.org; oss-
> drivers@...igine.com; linux-net-drivers@....com; leon@...nel.org
> Subject: [Intel-wired-lan] [PATCH net-next 1/3] net: ASSERT_RTNL
> remove netif_set_real_num_{rx, tx}_queues
> 
Can you consider more explicit title like:
net: remove redundant ASSERT_RTNL() in queue setup functions
?

> Existing netdev_ops_assert_locked takes care of asserting either
> netdev lock or RTNL.
> 
I'd recommend rephrasing like:
The existing netdev_ops_assert_locked() already asserts that either
the RTNL lock or the per-device lock is held, making the explicit
ASSERT_RTNL() redundant.


> Cc: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Stanislav Fomichev <stfomichev@...il.com>
> ---
>  net/core/dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c index
> fccf2167b235..5ea718036921 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct
> net_device *dev, unsigned int txq)
> 
>  	if (dev->reg_state == NETREG_REGISTERED ||
>  	    dev->reg_state == NETREG_UNREGISTERING) {
> -		ASSERT_RTNL();
>  		netdev_ops_assert_locked(dev);
> 
>  		rc = netdev_queue_update_kobjects(dev, dev-
> >real_num_tx_queues, @@ -3229,7 +3228,6 @@ int
> netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
>  		return -EINVAL;
> 
>  	if (dev->reg_state == NETREG_REGISTERED) {
> -		ASSERT_RTNL();
>  		netdev_ops_assert_locked(dev);
> 
>  		rc = net_rx_queue_update_kobjects(dev, dev-
> >real_num_rx_queues,
> --
> 2.49.0