linux-kernel - Re: [PATCH 0/7] net: Convert dev_set_mac_address() to struct sockaddr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <935B5950-190B-47D8-BF45-1CBAE904DB71@kernel.org>
Date: Tue, 20 May 2025 22:18:10 -0700
From: Kees Cook <kees@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
CC: Kuniyuki Iwashima <kuniyu@...zon.com>, ahmed.zaki@...el.com,
 aleksander.lobakin@...el.com, alex.aring@...il.com, andrew+netdev@...n.ch,
 ardb@...nel.org, christophe.leroy@...roup.eu, cratiu@...dia.com,
 d.bogdanov@...ro.com, davem@...emloft.net, decui@...rosoft.com,
 dianders@...omium.org, ebiggers@...gle.com, edumazet@...gle.com,
 fercerpav@...il.com, gmazyland@...il.com, grundler@...omium.org,
 haiyangz@...rosoft.com, hayeswang@...ltek.com, hch@....de, horms@...nel.org,
 idosch@...dia.com, jiri@...nulli.us, jv@...sburgh.net, kch@...dia.com,
 kys@...rosoft.com, leiyang@...hat.com, linux-hardening@...r.kernel.org,
 linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-nvme@...ts.infradead.org, linux-scsi@...r.kernel.org,
 linux-usb@...r.kernel.org, linux-wpan@...r.kernel.org, linux@...blig.org,
 martin.petersen@...cle.com, mgurtovoy@...dia.com,
 michael.christie@...cle.com, mingzhe.zou@...ystack.cn,
 miquel.raynal@...tlin.com, mlombard@...hat.com, netdev@...r.kernel.org,
 pabeni@...hat.com, phahn-oss@....de, sagi@...mberg.me, sam@...dozajonas.com,
 sdf@...ichev.me, shaw.leon@...il.com, stefan@...enfreihafen.org,
 target-devel@...r.kernel.org, viro@...iv.linux.org.uk, wei.liu@...nel.org
Subject: Re: [PATCH 0/7] net: Convert dev_set_mac_address() to struct sockaddr_storage



On May 20, 2025 8:09:29 PM PDT, Jakub Kicinski <kuba@...nel.org> wrote:
>On Tue, 20 May 2025 17:42:32 -0700 Kees Cook wrote:
>> Ah yes, I can include that in the next version if you want? I was trying
>> to find a stopping point since everything kind of touches everything ...
>
>Looks like the build considers -Wincompatible-pointer-types to always
>imply -Werror or some such? We explicitly disable CONFIG_WERROR in our
>CI, but we still get:
>
>drivers/net/macvlan.c:1302:34: error: incompatible pointer types passing 'struct sockaddr *' to parameter of type 'struct __kernel_sockaddr_storage *' [-Werror,-Wincompatible-pointer-types]
> 1302 |                 dev_set_mac_address(port->dev, &sa, NULL);
>      |                                                ^~~
>
>on this series :(

I'll get this fixed and add dev_set_mac_address_user() for v3...


-- 
Kees Cook