linux-kernel - Re: [PATCH] gpio: davinci: select GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfbQMebHDa4_=79ZaFRf_0V47wQHh8bP+MQh1Qj=wjOyA@mail.gmail.com>
Date: Wed, 21 May 2025 09:29:33 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: linus.walleij@...aro.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

On Wed, May 21, 2025 at 9:22 AM Peng Fan (OSS) <peng.fan@....nxp.com> wrote:
>
> From: Peng Fan <peng.fan@....com>
>
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
>
> Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505210606.PudPm5pC-lkp@intel.com/
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>
> Hi Bartosz,
>
>  I follow same approach as you did.
>  My last build using multi defconfig was not enough.
>  I tried build all arch/arm/configs/*, no errors with this patch applied.
>
> Thanks,
> Peng
>
>  drivers/gpio/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index a559d5bb8249..c3465fd82b08 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -253,6 +253,7 @@ config GPIO_DAVINCI
>         tristate "TI Davinci/Keystone GPIO support"
>         default y if ARCH_DAVINCI
>         depends on ((ARM || ARM64) && (ARCH_DAVINCI || ARCH_KEYSTONE || ARCH_K3)) || COMPILE_TEST
> +       select GPIOLIB_IRQCHIP
>         help
>           Say yes here to enable GPIO support for TI Davinci/Keystone SoCs.
>
> --
> 2.37.1
>

Ah, you beat me to it by 2 minutes.

Bart