linux-kernel - RE: [PATCH] gpio: davinci: select GPIOLIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8459A099FF0649D61BD21218889EA@PAXPR04MB8459.eurprd04.prod.outlook.com>
Date: Wed, 21 May 2025 07:33:31 +0000
From: Peng Fan <peng.fan@....com>
To: Bartosz Golaszewski <brgl@...ev.pl>, "Peng Fan (OSS)"
	<peng.fan@....nxp.com>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, kernel test
 robot <lkp@...el.com>
Subject: RE: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP

> Subject: Re: [PATCH] gpio: davinci: select GPIOLIB_IRQCHIP
> 
> On Wed, May 21, 2025 at 9:22 AM Peng Fan (OSS)
> <peng.fan@....nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@....com>
> >
> > This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> > are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig
> select.
> >
> > Fixes: 3f50bb3124d7 ("gpio: davinci: Make irq_chip immutable")
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes:
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F
> lore
> > .kernel.org%2Foe-kbuild-all%2F202505210606.PudPm5pC-
> lkp%40intel.com%2F
> >
> &data=05%7C02%7Cpeng.fan%40nxp.com%7C643974af18114f5850b
> 208dd9839437e%
> >
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6388340938
> 85187545%7CUnkn
> >
> own%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMD
> AwMCIsIlAiOiJX
> >
> aW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdat
> a=GCJh4QciYp
> > JMPAQQD63sh0jdUbkNcxQ5bbfxnLwDLfs%3D&reserved=0
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >
> > Hi Bartosz,
> >
> >  I follow same approach as you did.
> >  My last build using multi defconfig was not enough.
> >  I tried build all arch/arm/configs/*, no errors with this patch applied.
> >
> > Thanks,
> > Peng
> >
> >  drivers/gpio/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index
> > a559d5bb8249..c3465fd82b08 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -253,6 +253,7 @@ config GPIO_DAVINCI
> >         tristate "TI Davinci/Keystone GPIO support"
> >         default y if ARCH_DAVINCI
> >         depends on ((ARM || ARM64) && (ARCH_DAVINCI ||
> ARCH_KEYSTONE
> > || ARCH_K3)) || COMPILE_TEST
> > +       select GPIOLIB_IRQCHIP
> >         help
> >           Say yes here to enable GPIO support for TI Davinci/Keystone
> SoCs.
> >
> > --
> > 2.37.1
> >
> 
> Ah, you beat me to it by 2 minutes.

No problem, just drop my patch. Pick yours, since I copied
you idea on the fix.

Thanks,
Peng

> 
> Bart