linux-kernel - Re: [PATCH v2 05/10] sctp: use skb_crc32c() instead of __skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <faacdc3b-260a-46b5-b244-ff1575d5e6ef@suse.de>
Date: Wed, 21 May 2025 12:14:06 +0200
From: Hannes Reinecke <hare@...e.de>
To: Eric Biggers <ebiggers@...nel.org>, netdev@...r.kernel.org
Cc: linux-nvme@...ts.infradead.org, linux-sctp@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 Daniel Borkmann <daniel@...earbox.net>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
 Sagi Grimberg <sagi@...mberg.me>, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2 05/10] sctp: use skb_crc32c() instead of
 __skb_checksum()

On 5/19/25 19:50, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Make sctp_compute_cksum() just use the new function skb_crc32c(),
> instead of calling __skb_checksum() with a skb_checksum_ops struct that
> does CRC32C.  This is faster and simpler.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>   include/net/sctp/checksum.h | 29 +++--------------------------
>   net/netfilter/Kconfig       |  4 ++--
>   net/netfilter/ipvs/Kconfig  |  2 +-
>   net/openvswitch/Kconfig     |  2 +-
>   net/sched/Kconfig           |  2 +-
>   net/sctp/Kconfig            |  1 -
>   net/sctp/offload.c          |  1 -
>   7 files changed, 8 insertions(+), 33 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich