linux-kernel - Re: [PATCH v2 06/10] net: fold __skb_checksum() into skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c46209ce-3e28-4a18-83c2-3ff6d442cf8d@suse.de>
Date: Wed, 21 May 2025 12:14:47 +0200
From: Hannes Reinecke <hare@...e.de>
To: Eric Biggers <ebiggers@...nel.org>, netdev@...r.kernel.org
Cc: linux-nvme@...ts.infradead.org, linux-sctp@...r.kernel.org,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 Daniel Borkmann <daniel@...earbox.net>,
 Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
 Sagi Grimberg <sagi@...mberg.me>, Ard Biesheuvel <ardb@...nel.org>
Subject: Re: [PATCH v2 06/10] net: fold __skb_checksum() into skb_checksum()

On 5/19/25 19:50, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
> 
> Now that the only remaining caller of __skb_checksum() is
> skb_checksum(), fold __skb_checksum() into skb_checksum().  This makes
> struct skb_checksum_ops unnecessary, so remove that too and simply do
> the "regular" net checksum.  It also makes the wrapper functions
> csum_partial_ext() and csum_block_add_ext() unnecessary, so remove those
> too and just use the underlying functions.
> 
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>   include/linux/skbuff.h |  9 -------
>   include/net/checksum.h | 12 ---------
>   net/core/skbuff.c      | 59 +++++-------------------------------------
>   3 files changed, 7 insertions(+), 73 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich