linux-kernel - Re: [PATCH 1/2] staging: sm750fb: rename dprBase to dpr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025052112-creole-brush-7038@gregkh>
Date: Wed, 21 May 2025 13:47:22 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eric Florin <ericflorin@...gle.com>
Cc: teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: sm750fb: rename dprBase to dpr_base

On Sun, May 18, 2025 at 03:09:46PM -0700, Eric Florin wrote:
> Rename `dprBase` to `dpr_base` to conform with kernel style guidelines
> as reported by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <dprBase>
> 
> Signed-off-by: Eric Florin <ericflorin@...gle.com>
> ---
>  drivers/staging/sm750fb/sm750.h       | 2 +-
>  drivers/staging/sm750fb/sm750_accel.c | 4 ++--
>  drivers/staging/sm750fb/sm750_hw.c    | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index aff69661c8e6..a2342c69a65a 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -50,7 +50,7 @@ struct init_status {
>  
>  struct lynx_accel {
>  	/* base virtual address of DPR registers */
> -	volatile unsigned char __iomem *dprBase;
> +	volatile unsigned char __iomem *dpr_base;

Are you sure this isn't coming directly from a hardware data sheet or
description somewhere?  Based on the type, it really looks like it is.
If not, please document it properly that you have researched this in the
changelog text when resending.

Don't change variable names that reflect external names, that just makes
for more confusion over time.

thanks,

greg k-h