linux-kernel - Re: [PATCH 2/2] staging: sm750fb: rename dpPortBase in lynx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025052125-stew-customs-4ca9@gregkh>
Date: Wed, 21 May 2025 13:47:40 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Eric Florin <ericflorin@...gle.com>
Cc: teddy.wang@...iconmotion.com, sudipm.mukherjee@...il.com,
	linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: sm750fb: rename dpPortBase in lynx_accel

On Sun, May 18, 2025 at 03:09:47PM -0700, Eric Florin wrote:
> Rename `dpPortBase` to `dp_port_base` to conform with kernel style
> guidelines as reported by checkpatch.pl
> 
> CHECK: Avoid CamelCase: <dpPortBase>
> 
> Signed-off-by: Eric Florin <ericflorin@...gle.com>
> ---
>  drivers/staging/sm750fb/sm750.h       | 2 +-
>  drivers/staging/sm750fb/sm750_accel.c | 2 +-
>  drivers/staging/sm750fb/sm750_hw.c    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index a2342c69a65a..0ed1e18611ba 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -52,7 +52,7 @@ struct lynx_accel {
>  	/* base virtual address of DPR registers */
>  	volatile unsigned char __iomem *dpr_base;
>  	/* base virtual address of de data port */
> -	volatile unsigned char __iomem *dpPortBase;
> +	volatile unsigned char __iomem *dp_port_base;

Same here, are you sure this doesn't come directly from the hardware
spec?

thanks,

greg k-h