Message-ID: <20250522175623.1a6d9b14@booty>
Date: Thu, 22 May 2025 17:56:23 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann
 <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter
 <simona@...ll.ch>, Andrzej Hajda <andrzej.hajda@...el.com>, Neil Armstrong
 <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, Laurent
 Pinchart <Laurent.pinchart@...asonboard.com>, Jonas Karlman
 <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, Jagan Teki
 <jagan@...rulasolutions.com>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>, Douglas Anderson
 <dianders@...omium.org>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Krzysztof
 Kozlowski <krzk@...nel.org>, Liu Ying <victor.liu@....com>, Anusha Srivatsa
 <asrivats@...hat.com>, Paul Kocialkowski <paulk@...-base.io>, Dmitry
 Baryshkov <lumag@...nel.org>, Hui Pu <Hui.Pu@...ealthcare.com>, Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>, dri-devel@...ts.freedesktop.org,
 asahi@...ts.linux.dev, linux-kernel@...r.kernel.org,
 chrome-platform@...ts.linux.dev, imx@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 linux-amlogic@...ts.infradead.org, linux-renesas-soc@...r.kernel.org,
 platform-driver-x86@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 linux-arm-msm@...r.kernel.org, freedreno@...ts.freedesktop.org,
 linux-stm32@...md-mailman.stormreply.com, Louis Chauvet
 <louis.chauvet@...tlin.com>, Alim Akhtar <alim.akhtar@...sung.com>, Inki
 Dae <inki.dae@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>,
 Seung-Woo Kim <sw0312.kim@...sung.com>, Manikandan Muralidharan
 <manikandan.m@...rochip.com>, Adam Ford <aford173@...il.com>, Adrien
 Grassein <adrien.grassein@...il.com>, Aleksandr Mishin
 <amishin@...rgos.ru>, Andy Yan <andy.yan@...k-chips.com>, AngeloGioacchino
 Del Regno <angelogioacchino.delregno@...labora.com>, Benson Leung
 <bleung@...omium.org>, Biju Das <biju.das.jz@...renesas.com>, Christoph
 Fritz <chf.fritz@...glemail.com>, Cristian Ciocaltea
 <cristian.ciocaltea@...labora.com>, Detlev Casanova
 <detlev.casanova@...labora.com>, Dharma Balasubiramani
 <dharma.b@...rochip.com>, Guenter Roeck <groeck@...omium.org>, Heiko
 Stuebner <heiko@...ech.de>, Jani Nikula <jani.nikula@...el.com>, Janne
 Grunau <j@...nau.net>, Jerome Brunet <jbrunet@...libre.com>, Jesse Van
 Gavere <jesseevg@...il.com>, Kevin Hilman <khilman@...libre.com>, Kieran
 Bingham <kieran.bingham+renesas@...asonboard.com>, Martin Blumenstingl
 <martin.blumenstingl@...glemail.com>, Matthias Brugger
 <matthias.bgg@...il.com>, Philipp Zabel <p.zabel@...gutronix.de>, Phong LE
 <ple@...libre.com>, Sasha Finkelstein <fnkl.kernel@...il.com>, Sugar Zhang
 <sugar.zhang@...k-chips.com>, Sui Jingfeng <sui.jingfeng@...ux.dev>, Tomi
 Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, Vitalii Mordan
 <mordan@...ras.ru>, "Rob Herring (Arm)" <robh@...nel.org>, Hsin-Te Yuan
 <yuanhsinte@...omium.org>, Pin-yen Lin <treapking@...omium.org>, Xin Ji
 <xji@...logixsemi.com>, Aradhya Bhatia <a-bhatia1@...com>, Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>, Ian Ray <ian.ray@...ealthcare.com>,
 Martyn Welch <martyn.welch@...labora.co.uk>, Peter Senna Tschudin
 <peter.senna@...il.com>, Helge Deller <deller@....de>, Kuninori Morimoto
 <kuninori.morimoto.gx@...esas.com>, Laurent Pinchart
 <laurent.pinchart+renesas@...asonboard.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Philippe Cornu <philippe.cornu@...s.st.com>,
 Raphael Gallais-Pou <raphael.gallais-pou@...s.st.com>, Yannick Fertre
 <yannick.fertre@...s.st.com>, Alain Volmat <alain.volmat@...s.st.com>,
 Raphael Gallais-Pou <rgallaispou@...il.com>, Michal Simek
 <michal.simek@....com>, Jonathan Corbet <corbet@....net>,
 linux-doc@...r.kernel.org
Subject: Re: [PATCH v3 00/22] drm: convert all bridges to
 devm_drm_bridge_alloc()

Hi Maxime,

On Thu, 22 May 2025 16:57:30 +0200
Maxime Ripard <mripard@...nel.org> wrote:

[...]

> > As the commit was a mistake, I'm applying the revert by the end of this
> > week (i.e. on Friday) unless there are better instructions.  
> 
> Given the lack of answers, and that it looks correct to me, just leave
> it there. We can always revert later on if things turned out to be
> broken.

OK, I'll leave the commit and drop the revert in v4.

> > >       drm: convert many bridge drivers from devm_kzalloc() to devm_drm_bridge_alloc() API  
> > 
> > This patch affects multiple drivers. Running get_maintainers.pl
> > points at Shawn Guo's repository. After reviewing the MAINTAINERS file,
> > this looks like due to the 'N:' line in:
> > 
> > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > M:	Shawn Guo <shawnguo@...nel.org>
> > M:	Sascha Hauer <s.hauer@...gutronix.de>
> > R:	Pengutronix Kernel Team <kernel@...gutronix.de>
> > ...
> > T:	git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git
> > N:	imx
> > ...
> > 
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L2511-2528)
> > 
> > Here 'imx' matches the 'drivers/gpu/drm/bridge/imx/imx-legacy-bridge.c'
> > file that is touched by the patch. That regexp appears overly generic to me.  
> 
> I agree, or at least, we shouldn't wait for Shawn or Sasha...
> 
> > Shawn, can it be fixed by making it less generic?
> > 
> > If not, can we at least add a band-aid 'X:' entry for
> > drivers/gpu/drm/bridge/imx?
> > 
> > I think the other matching entry is the one to consider:
> > 
> > DRM DRIVERS FOR FREESCALE IMX BRIDGE
> > M:	Liu Ying <victor.liu@....com>
> > L:	dri-devel@...ts.freedesktop.org
> > S:	Maintained
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-ldb.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-combiner.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-link.yaml
> > F:	Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pxl2dpi.yaml
> > F:	drivers/gpu/drm/bridge/imx/
> > 
> > (https://gitlab.freedesktop.org/drm/misc/kernel/-/blob/drm-misc-next/MAINTAINERS?ref_type=heads#L7940-7948)  
> 
> ... As long as Ying is fine with it, because it does look like they are
> the actual maintainer.

Ack, thanks for confirming this.

Bottom line, given that large patch has your Acked-by, and given the
shawnguo repo was ruled out, the conclusion is it can apply it to
drm-misc-next.

Having that large patch applied will be relieving me a lot! I think
next time I'm going to split any imilar change in per-driver patches,
even if it is spatch-automated.

> > >       drm/todo: add entry to remove devm_drm_put_bridge()  
> > 
> > This involves documentation maintained on another tree. Where should it
> > be applied? There are two matching entries in MAINTAINERS:
> > 
> >  * DRM DRIVERS -> the drm tree
> >  * DRM DRIVERS AND MISC GPU PATCHES -> the drm-misc tree
> > 
> > To me it looks like the second is obviously the closest match as we are
> > dealing with DRM bridges, so I'm applying this as well on Friday unless
> > there are better instructions.  
> 
> Yes, they should be applied to drm-misc.

OK, will do soon.

> That being said, putting a two days timeout on *any* email is really
> over-the-top. I doubt you reply to any of your mail in such a short
> timeframe. We have rules for a reason, I'd expect you to follow them, no
> matter how frustrating the lack of answers can be.

Apologies if that was too much.

I was indeed nervous about the revert. A patch got applied by mistake
and I believe it should have been reverted very quickly, if need be.
Both Louis and I didn't want to break the process again. So we asked,
but not having answer after 2+ weeks I must admit I got a bit nervous
about it.

Sorry about that and thanks for the feedback about my questions.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Powered by blists - more mailing lists