linux-kernel - Re: [PATCH v6 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <706858ca-7ebf-4419-a096-3907aab923bf@app.fastmail.com>
Date: Thu, 22 May 2025 18:14:56 +0200
From: "Sven Peter" <sven@...npeter.dev>
To: "Sebastian Reichel" <sebastian.reichel@...labora.com>
Cc: "Janne Grunau" <j@...nau.net>, "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
 "Neal Gompa" <neal@...pa.dev>, "Hector Martin" <marcan@...can.st>,
 "Linus Walleij" <linus.walleij@...aro.org>,
 "Bartosz Golaszewski" <brgl@...ev.pl>, "Rob Herring" <robh@...nel.org>,
 "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 "Conor Dooley" <conor+dt@...nel.org>, "Lee Jones" <lee@...nel.org>,
 "Marc Zyngier" <maz@...nel.org>, "Russell King" <rmk+kernel@...linux.org.uk>,
 asahi@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v6 07/10] power: reset: macsmc-reboot: Add driver for rebooting via
 Apple SMC

Hi Sebastian,

On Thu, May 22, 2025, at 15:06, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 15, 2025 at 06:21:19AM +0000, Sven Peter via B4 Relay wrote:
>> From: Hector Martin <marcan@...can.st>
>> 
>> This driver implements the reboot/shutdown support exposed by the SMC
>> on Apple Silicon machines, such as Apple M1 Macs.
>> 

[...]

>> +
>> +static int macsmc_reboot_probe(struct platform_device *pdev)
>> +{
>> +	struct apple_smc *smc = dev_get_drvdata(pdev->dev.parent);
>> +	struct macsmc_reboot *reboot;
>> +	int ret, i;
>> +
>> +	/* Ignore devices without this functionality */
>> +	if (!apple_smc_key_exists(smc, SMC_KEY(MBSE)))
>> +		return -ENODEV;
>
> Is that a leftover? I would expect that you do not have the
> 'apple,smc-reboot' sub-device described in DT for such a case.

Yup, that's another leftover, will remove it for v7 as well.

>
> Otherwise
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>


Thanks for the review!


Sven