linux-kernel - Re: [????] Re: [PATCH] vfio/type1: fixed rollback in vfio_dma_bitmap_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250522115231.729dad0c.alex.williamson@redhat.com>
Date: Thu, 22 May 2025 11:52:31 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: "Li,Rongqing" <lirongqing@...du.com>
Cc: "kwankhede@...dia.com" <kwankhede@...dia.com>, "yan.y.zhao@...el.com"
 <yan.y.zhao@...el.com>, "cjia@...dia.com" <cjia@...dia.com>,
 "kvm@...r.kernel.org" <kvm@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>
Subject: Re: [????] Re: [PATCH] vfio/type1: fixed rollback in
 vfio_dma_bitmap_alloc_all()

On Thu, 22 May 2025 01:53:48 +0000
"Li,Rongqing" <lirongqing@...du.com> wrote:

> >     vfio/type1: Fix error unwind in migration dirty bitmap allocation
> > 
> >     When setting up dirty page tracking at the vfio IOMMU backend for
> >     device migration, if an error is encountered allocating a tracking
> >     bitmap, the unwind loop fails to free previously allocated tracking
> >     bitmaps.  This occurs because the wrong loop index is used to
> >     generate the tracking object.  This results in unintended memory
> >     usage for the life of the current DMA mappings where bitmaps were
> >     successfully allocated.
> > 
> >     Use the correct loop index to derive the tracking object for
> >     freeing during unwind.
> >   
> 
> Your changelog is extremely detailed and highly accurate.
> 
> Please directly incorporate this patch with your changelog

Applied to vfio next branch for v6.16 with updated changelog.  Thanks,

Alex