linux-kernel - Re: [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871d18ab-a696-4141-bc3a-7b6e968fc649@kernel.org>
Date: Thu, 22 May 2025 21:54:28 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rosen Penev <rosenp@...il.com>, linux-wireless@...r.kernel.org
Cc: Toke Høiland-Jørgensen <toke@...e.dk>,
 Johannes Berg <johannes@...solutions.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>,
 "open list:MIPS" <linux-mips@...r.kernel.org>
Subject: Re: [PATCHv2 4/5] dt-bindings: net: wireless: ath9k: add OF bindings

On 22/05/2025 20:45, Rosen Penev wrote:
> Now that support was added to the driver, document it.

That's not appropriate commit msg. Binding must be before the user (see
submitting patches in DT directory). Describe the hardware, what are you
adding here.

Subject: OF bindings is redundant. It duplicates dt-bindings. Instead:
"Add Atheros AR9-foo-bar on AHB bus" or something similar

Missing SoB.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.



> ---
>  .../bindings/net/wireless/qca,ath9k.yaml      | 23 ++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> index 0e5412cff2bc..81d00f257922 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qca,ath9k.yaml
> @@ -12,7 +12,7 @@ maintainers:
>  description: |
>    This node provides properties for configuring the ath9k wireless device.
>    The node is expected to be specified as a child node of the PCI controller
> -  to which the wireless chip is connected.
> +  or AHB bus to which the wireless chip is connected.
>  
>  allOf:
>    - $ref: ieee80211.yaml#
> @@ -35,6 +35,12 @@ properties:
>        - pci168c,0034  # AR9462
>        - pci168c,0036  # AR9565
>        - pci168c,0037  # AR1111 and AR9485
> +      - qca,ar9130-wmac
> +      - qca,ar9330-wmac
> +      - qca,ar9340-wmac
> +      - qca,qca9530-wmac
> +      - qca,qca9550-wmac
> +      - qca,qca9560-wmac
>  
>    reg:
>      maxItems: 1
> @@ -88,3 +94,18 @@ examples:
>          nvmem-cell-names = "mac-address", "calibration";
>        };
>      };
> +  - |
> +    apb {
> +      compatible = "simple-bus";
> +      ranges;
> +

Drop these two.

> +      #address-cells = <1>;
> +      #size-cells = <1>;

Best regards,
Krzysztof