linux-kernel - Re: Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d51263a0-50df-490c-84c9-ebd0ac49d7d1@linuxfoundation.org>
Date: Thu, 22 May 2025 15:55:23 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: rujra <braker.noob.kernel@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel-mentees@...ts.linux.dev, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: Fwd: [PATCH] selftests : timers : valid-adjtimex.c : Fixed style
 checks

On 5/15/25 19:44, rujra wrote:
> fixed style checks according to Linux Kernel Coding Style standards.

Fixes

> 
> 
> 1 : fixed alignment of parenthesis.
> LOG : CHECK: Alignment should match open parenthesis
> +                       printf("ERROR: out of range value %ld actually set!\n",
> +                                       tx.freq);
> 
> 2 : fixed alignment of parenthesis.
> LOG : CHECK: Alignment should match open parenthesis
> +                               printf("Error: No failure on invalid
> ADJ_FREQUENCY %ld\n",
> +                                       invalid_freq[i]);
> 
> 3 : fixed line length of 106 to 100 and less.
> LOG :  CHECK: line length of 106 exceeds 100 columns
> +               printf("Invalid (sec: %ld  usec: %ld) did not fail! ",
> tmx.time.tv_sec, tmx.time.tv_usec);

Please refer to a few logs for examples on how to write change logs.
Also check kernel documentation on submitting patches.

thanks,
-- Shuah