linux-kernel - Re: [PATCH v3 1/3] dt-bindings: can: rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed51c57a-35c4-43e4-9041-221026fb6273@kernel.org>
Date: Thu, 22 May 2025 08:58:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Elaine Zhang <zhangqing@...k-chips.com>, mkl@...gutronix.de,
 kernel@...gutronix.de, mailhol.vincent@...adoo.fr, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de, cl@...k-chips.com,
 kever.yang@...k-chips.com
Cc: linux-can@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: can: rockchip_canfd: add rk3576
 CAN-FD controller

On 22/05/2025 08:32, Elaine Zhang wrote:
> Add documentation for the rockchip rk3576 CAN-FD controller.
> 
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> ---
>  .../net/can/rockchip,rk3576-canfd.yaml        | 82 +++++++++++++++++++
>  1 file changed, 82 insertions(+)

There is no cover letter (maybe something got lost on the lists?), no
changelog. What was happening with this patch?


>  create mode 100644 Documentation/devicetree/bindings/net/can/rockchip,rk3576-canfd.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/can/rockchip,rk3576-canfd.yaml b/Documentation/devicetree/bindings/net/can/rockchip,rk3576-canfd.yaml
> new file mode 100644
> index 000000000000..85caf6d19607
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/rockchip,rk3576-canfd.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/can/rockchip,rk3568v2-canfd.yaml#

Never tested, so just quick glance, not review.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title:


That's never a line break. Open existing files and look how it is done
there.


> +  Rk3576 CAN-FD controller


...


> +
> +        can0: can@...00000 {

Drop label

> +            compatible = "rockchip,rk3576-canfd";

Messed indentation

> +	    reg = <0x0 0x2ac00000 0x0 0x1000>;
> +	    interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>;
> +	    clocks = <&cru CLK_CAN0>, <&cru HCLK_CAN0>;
> +	    clock-names = "baud", "pclk";
> +	    resets = <&cru SRST_CAN0>, <&cru SRST_H_CAN0>;
> +	    reset-names = "can", "can-apb";
> +	    dmas = <&dmac0 20>;
> +	    dma-names = "rx";
> +	    status = "disabled";

No, it cannot be disabled. Drop. Look at other bindings or example-schema.

> +	};
> +    };


Best regards,
Krzysztof