linux-kernel - Re: [PATCH v3 2/3] net: can: rockchip: add can for RK3576 Soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMZ6RqJzR6ucRnCHFq8ZFRnznRsFYq6BMQY24aaROJMLWigU4A@mail.gmail.com>
Date: Thu, 22 May 2025 16:51:40 +0900
From: Vincent Mailhol <mailhol.vincent@...adoo.fr>
To: Elaine Zhang <zhangqing@...k-chips.com>
Cc: mkl@...gutronix.de, kernel@...gutronix.de, robh@...nel.org, 
	krzk+dt@...nel.org, conor+dt@...nel.org, heiko@...ech.de, cl@...k-chips.com, 
	kever.yang@...k-chips.com, linux-can@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/3] net: can: rockchip: add can for RK3576 Soc

On Thu. 22 May 2025 at 15:38, Elaine Zhang <zhangqing@...k-chips.com> wrote:
>
> Is new controller:
> Support CAN and CANFD protocol.
> Support Dma.

Please write a more verbose description with proper sentences.

> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>

You need to break this into several patches and several files.

You can not put everything in rockchip_canfd-core.c. Create a
rockchip_rk3568.c in which you will move all the already existing
rk3568 specific functions. Then, in another patch, create a
rockchip_rk3576.c that will contain all the new code. Also adjust the
headers accordingly.

Yours sincerely,
Vincent Mailhol