linux-kernel - linux-next: manual merge of the cgroup tree with the mm-stable, mm-unstable trees

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250522173518.68d11f41@canb.auug.org.au>
Date: Thu, 22 May 2025 17:35:18 +1000
From: Stephen Rothwell <sfr@...b.auug.org.au>
To: Tejun Heo <tj@...nel.org>, Andrew Morton <akpm@...ux-foundation.org>
Cc: JP Kobryn <inwardvessel@...il.com>, Linux Kernel Mailing List
 <linux-kernel@...r.kernel.org>, Linux Next Mailing List
 <linux-next@...r.kernel.org>, Lorenzo Stoakes <lorenzo.stoakes@...cle.com>,
 Shakeel Butt <shakeel.butt@...ux.dev>
Subject: linux-next: manual merge of the cgroup tree with the mm-stable,
 mm-unstable trees

Hi all,

Today's linux-next merge of the cgroup tree got a conflict in:

  mm/memcontrol.c

between commits:

  60cada258dfe ("memcg: optimize memcg_rstat_updated")
  ff9798e05d33 ("memcg: memcg_rstat_updated re-entrant safe against irqs")

from the mm-stable tree,

  dc1bc55490f4 ("memcg: make memcg_rstat_updated nmi safe")

from the mm-unstable tree and commit:

  a97915559f5c ("cgroup: change rstat function signatures from cgroup-based to css-based")

from the cgroup tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc mm/memcontrol.c
index 4e9771e6e340,fde0934e2837..000000000000
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@@ -573,22 -582,11 +573,22 @@@ static inline void memcg_rstat_updated(
  	if (!val)
  		return;
  
 -	css_rstat_updated(&memcg->css, cpu);
 -	statc = this_cpu_ptr(memcg->vmstats_percpu);
 -	for (; statc; statc = statc->parent) {
 -		stats_updates = READ_ONCE(statc->stats_updates) + abs(val);
 -		WRITE_ONCE(statc->stats_updates, stats_updates);
 +	/* TODO: add to cgroup update tree once it is nmi-safe. */
 +	if (!in_nmi())
- 		cgroup_rstat_updated(memcg->css.cgroup, cpu);
++		css_rstat_updated(&memcg->css, cpu);
 +	statc_pcpu = memcg->vmstats_percpu;
 +	for (; statc_pcpu; statc_pcpu = statc->parent_pcpu) {
 +		statc = this_cpu_ptr(statc_pcpu);
 +		/*
 +		 * If @memcg is already flushable then all its ancestors are
 +		 * flushable as well and also there is no need to increase
 +		 * stats_updates.
 +		 */
 +		if (memcg_vmstats_needs_flush(statc->vmstats))
 +			break;
 +
 +		stats_updates = this_cpu_add_return(statc_pcpu->stats_updates,
 +						    abs(val));
  		if (stats_updates < MEMCG_CHARGE_BATCH)
  			continue;
  

Content of type "application/pgp-signature" skipped