linux-kernel - Re: [PATCH 2/2] ASoC: codecs: add support for ES8375

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202505221528.nvWwf9kj-lkp@intel.com>
Date: Thu, 22 May 2025 15:36:02 +0800
From: kernel test robot <lkp@...el.com>
To: Zhang Yi <zhangyi@...rest-semi.com>, broonie@...nel.org,
	robh@...nel.org, tiwai@...e.com, devicetree@...r.kernel.org,
	conor+dt@...nel.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org, linux-sound@...r.kernel.org,
	perex@...ex.cz, krzk+dt@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	amadeuszx.slawinski@...ux.intel.com, krzk@...nel.org,
	Zhang Yi <zhangyi@...rest-semi.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: add support for ES8375

Hi Zhang,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on next-20250521]
[cannot apply to tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Zhang-Yi/ASoC-dt-bindings-Add-Everest-ES8375-audio-CODEC/20250521-184427
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20250521104247.6595-3-zhangyi%40everest-semi.com
patch subject: [PATCH 2/2] ASoC: codecs: add support for ES8375
config: x86_64-buildonly-randconfig-001-20250522 (https://download.01.org/0day-ci/archive/20250522/202505221528.nvWwf9kj-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250522/202505221528.nvWwf9kj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505221528.nvWwf9kj-lkp@intel.com/

All errors (new ones prefixed by >>):

>> sound/soc/codecs/es8375.c:706:7: error: use of undeclared identifier 'i'
     706 |         for (i = 0; i < ARRAY_SIZE(es8375_core_supplies); i++)
         |              ^
   sound/soc/codecs/es8375.c:706:14: error: use of undeclared identifier 'i'
     706 |         for (i = 0; i < ARRAY_SIZE(es8375_core_supplies); i++)
         |                     ^
   sound/soc/codecs/es8375.c:706:52: error: use of undeclared identifier 'i'
     706 |         for (i = 0; i < ARRAY_SIZE(es8375_core_supplies); i++)
         |                                                           ^
   sound/soc/codecs/es8375.c:707:23: error: use of undeclared identifier 'i'
     707 |                 es8375->core_supply[i].supply = es8375_core_supplies[i];
         |                                     ^
   sound/soc/codecs/es8375.c:707:56: error: use of undeclared identifier 'i'
     707 |                 es8375->core_supply[i].supply = es8375_core_supplies[i];
         |                                                                      ^
   5 errors generated.


vim +/i +706 sound/soc/codecs/es8375.c

   691	
   692	static int es8375_read_device_properities(struct device *dev, struct es8375_priv *es8375)
   693	{
   694		int ret;
   695	
   696		ret = device_property_read_u8(dev, "everest,mclk-src", &es8375->mclk_src);
   697		if (ret != 0)
   698			es8375->mclk_src = ES8375_MCLK_SOURCE;
   699		dev_dbg(dev, "mclk-src %x", es8375->mclk_src);
   700	
   701		ret = device_property_read_u8(dev, "everest,dmic-pol", &es8375->dmic_pol);
   702		if (ret != 0)
   703			es8375->dmic_pol = DMIC_POL;
   704		dev_dbg(dev, "dmic-pol %x", es8375->dmic_pol);
   705	
 > 706		for (i = 0; i < ARRAY_SIZE(es8375_core_supplies); i++)
   707			es8375->core_supply[i].supply = es8375_core_supplies[i];
   708		ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(es8375_core_supplies), es8375->core_supply);
   709		if (ret) {
   710			dev_err(dev, "Failed to request core supplies %d\n", ret);
   711			return ret;
   712		}
   713	
   714		es8375->mclk = devm_clk_get(dev, "mclk");
   715		if (IS_ERR(es8375->mclk))
   716			return dev_err_probe(dev, PTR_ERR(es8375->mclk), "unable to get mclk\n");
   717	
   718		if (!es8375->mclk)
   719			dev_warn(dev, "assuming static mclk\n");
   720	
   721		ret = clk_prepare_enable(es8375->mclk);
   722		if (ret) {
   723			dev_err(dev, "unable to enable mclk\n");
   724			return ret;
   725		}
   726		ret = regulator_bulk_enable(ARRAY_SIZE(es8375_core_supplies), es8375->core_supply);
   727		if (ret) {
   728			dev_err(dev, "Failed to enable core supplies: %d\n", ret);
   729			clk_disable_unprepare(es8375->mclk);
   730			return ret;
   731		}
   732	
   733		return 0;
   734	}
   735	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki