Message-ID: <5291df1a-d44f-493e-9655-0bf13a4a7a59@pengutronix.de>
Date: Thu, 22 May 2025 09:36:42 +0200
From: Ahmad Fatoum <a.fatoum@...gutronix.de>
To: Krzysztof Kozlowski <krzk@...nel.org>,
 Maud Spierings | GOcontroll <maudspierings@...ontroll.com>,
 Shawn Guo <shawnguo2@...h.net>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Fabio Estevam <festevam@...il.com>, Sascha Hauer <s.hauer@...gutronix.de>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>,
 "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 3/8] MAINTAINERS: add maintainer for the Ka-Ro
 tx8p-ml81 COM module

Hi Krzysztof,

On 22.05.25 08:19, Krzysztof Kozlowski wrote:
> On 21/05/2025 22:39, Ahmad Fatoum wrote:
>> Dear Device Tree Maintainers,
>> Dear Maud and Shawn,
>>
>> On 09.05.25 11:03, Maud Spierings | GOcontroll wrote:
>>> On 5/9/25 10:58, Shawn Guo wrote:
>>>>>>> +KA-RO TX8P COM MODULE
>>>>>>> +M:	Maud Spierings <maudspierings@...ontroll.com>
>>>>>>> +L:	imx@...ts.linux.dev
>>>>>>> +S:	Maintained
>>>>>>> +F:	arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81.dtsi
>>>>>>> +
>>>>>>
>>>>>> I'm not fond of such changes, as MAINTAINERS file could be bloated
>>>>>> quickly by individual DTS.
>>>>>
>>>>> Is there some way you would prefer to see it? I don't really know of a better
>>>>> way.
>>>>
>>>> There was some discussion about getting ./scripts/get_maintainer.pl pick
>>>> up the Author: field (in DTS header area).  But I'm not sure where it
>>>> ended.
>>>
>>> I feel like that would be wrong in this situation too, it would pull in
>>> Lothar Wassmann, who has nothing to do with me upstreaming this. I have
>>> seen him around on the mailing list but given that Ka-Ro are not
>>> upstreaming these themselves, I feel it would be weird to pull him into
>>> this.
>>
>> We can add multiple authors. Authors not wishing to receive mail can always
>> remove their name or blackhole their mail address via the mailmap.
>>
>> I am not leaning strongly in favor of either way, but I am bothered a little
>> by b4 nagging me about adding MAINTAINERS entry for device trees that I've
>> added. It would be nice to have a guideline here.
> 
> Hm? That's not a warning anyone should fix. If any of these patches are
> because of checkpatch, then obviously this should never be accepted.

If we come to an agreement that in the general case, MAINTAINER entries
are not desired for device trees, we should fix the tooling to not mislead
contributors.

> And that's true for every other change, every addition of C or H file.
> You do not add maintainer entries for them.

I guess it's more of a nudge to make the contributor think about whether the
change is adequately covered by existing MAINTAINERS entries or not.
People have time and time again came to different conclusions for that
regarding device trees though.

It would be nice if we could put that to rest by 1) documenting it
and 2) fixing the tooling to not nag about it or to have a more suitable
message concerning device trees.

I am happy to implement either thing into checkpatch.pl.
Just let me know what way we should go.

Thank you,
Ahmad

> 
>>
> 
> 
> Best regards,
> Krzysztof
> 


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Powered by blists - more mailing lists