linux-kernel - Re: [PATCH 1/1] usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DA2IV4ZGT2M8.3QXO3L57VXSA5@brighamcampbell.com>
Date: Thu, 22 May 2025 01:47:54 -0600
From: "Brigham Campbell" <me@...ghamcampbell.com>
To: "Jihed Chaibi" <jihed.chaibi.dev@...il.com>,
 <heikki.krogerus@...ux.intel.com>, <gregkh@...uxfoundation.org>
Cc: <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <linux-kernel-mentees@...ts.linux.dev>, <skhan@...uxfoundation.org>
Subject: Re: [PATCH 1/1] usb: typec: tipd: fix typo in
 TPS_STATUS_HIGH_VOLAGE_WARNING macro

On Wed May 21, 2025 at 3:48 PM MDT, Jihed Chaibi wrote:
> "VOLAGE" should become "VOLTAGE"
>
> Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>

Nice work! I was able to successfully compile this driver with your
changes and I don't see any further references to the misspelled macro.

Patches which fix issues which were introduced in some previous commit
typically indicate the offending commit via the "Fixes" tag. Admittedly,
I don't know if the tag is reserved for technical bugs rather than typos
such as the one you addressed, but such a tag would look like the
following for this patch:

Fixes: e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")

> ---
>  drivers/usb/typec/tipd/tps6598x.h | 2 +-
>  drivers/usb/typec/tipd/trace.h    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
> index 9b23e9017..cecb8d11d 100644
> --- a/drivers/usb/typec/tipd/tps6598x.h
> +++ b/drivers/usb/typec/tipd/tps6598x.h
> @@ -27,7 +27,7 @@
>  #define TPS_STATUS_OVERCURRENT		BIT(16)
>  #define TPS_STATUS_GOTO_MIN_ACTIVE	BIT(26)
>  #define TPS_STATUS_BIST			BIT(27)
> -#define TPS_STATUS_HIGH_VOLAGE_WARNING	BIT(28)
> +#define TPS_STATUS_HIGH_VOLTAGE_WARNING	BIT(28)
>  #define TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING BIT(29)
>  
>  #define TPS_STATUS_CONN_STATE_MASK		GENMASK(3, 1)
> diff --git a/drivers/usb/typec/tipd/trace.h b/drivers/usb/typec/tipd/trace.h
> index 0669cca12..bea383f2d 100644
> --- a/drivers/usb/typec/tipd/trace.h
> +++ b/drivers/usb/typec/tipd/trace.h
> @@ -153,7 +153,7 @@
>  		      { TPS_STATUS_OVERCURRENT,		"OVERCURRENT" }, \
>  		      { TPS_STATUS_GOTO_MIN_ACTIVE,	"GOTO_MIN_ACTIVE" }, \
>  		      { TPS_STATUS_BIST,		"BIST" }, \
> -		      { TPS_STATUS_HIGH_VOLAGE_WARNING,	"HIGH_VOLAGE_WARNING" }, \
> +		      { TPS_STATUS_HIGH_VOLTAGE_WARNING,	"HIGH_VOLTAGE_WARNING" }, \
>  		      { TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING, "HIGH_LOW_VOLTAGE_WARNING" })

Consider making "HIGH_LOW_VOLTAGE_WARNING" inline with
"HIGH_VOLTAGE_WARNING", or vice versa.

>  
>  #define show_tps25750_status_flags(flags) \

Reviewed-by: Brigham Campbell <me@...ghamcampbell.com>