[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2025052234-brewing-recall-a7ed@gregkh>
Date: Thu, 22 May 2025 10:30:48 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Brigham Campbell <me@...ghamcampbell.com>
Cc: Jihed Chaibi <jihed.chaibi.dev@...il.com>,
heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linux.dev,
skhan@...uxfoundation.org
Subject: Re: [PATCH 1/1] usb: typec: tipd: fix typo in
TPS_STATUS_HIGH_VOLAGE_WARNING macro
On Thu, May 22, 2025 at 01:47:54AM -0600, Brigham Campbell wrote:
> On Wed May 21, 2025 at 3:48 PM MDT, Jihed Chaibi wrote:
> > "VOLAGE" should become "VOLTAGE"
> >
> > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
>
> Nice work! I was able to successfully compile this driver with your
> changes and I don't see any further references to the misspelled macro.
>
> Patches which fix issues which were introduced in some previous commit
> typically indicate the offending commit via the "Fixes" tag. Admittedly,
> I don't know if the tag is reserved for technical bugs rather than typos
> such as the one you addressed, but such a tag would look like the
> following for this patch:
>
> Fixes: e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")
Too many characters for that sha1 value :)
thanks,
greg k-hj
Powered by blists - more mailing lists