linux-kernel - Re: [PATCH 1/1] usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANBuOYpm86aJtk9ubkjVSOeM=tctF7upbsyPYOP-Bf8bNnv-0w@mail.gmail.com>
Date: Thu, 22 May 2025 13:10:37 +0200
From: Jihed Chaibi <jihed.chaibi.dev@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Brigham Campbell <me@...ghamcampbell.com>, heikki.krogerus@...ux.intel.com, 
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-kernel-mentees@...ts.linux.dev, skhan@...uxfoundation.org
Subject: Re: [PATCH 1/1] usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING
 macro

On Thu, May 22, 2025 at 10:30 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, May 22, 2025 at 01:47:54AM -0600, Brigham Campbell wrote:
> > On Wed May 21, 2025 at 3:48 PM MDT, Jihed Chaibi wrote:
> > > "VOLAGE" should become "VOLTAGE"
> > >
> > > Signed-off-by: Jihed Chaibi <jihed.chaibi.dev@...il.com>
> >
> > Nice work! I was able to successfully compile this driver with your
> > changes and I don't see any further references to the misspelled macro.
> >
> > Patches which fix issues which were introduced in some previous commit
> > typically indicate the offending commit via the "Fixes" tag. Admittedly,
> > I don't know if the tag is reserved for technical bugs rather than typos
> > such as the one you addressed, but such a tag would look like the
> > following for this patch:
> >
> > Fixes: e011178579b57c03 ("usb: typec: tipd: fix typo in TPS_STATUS_HIGH_VOLAGE_WARNING macro")
>
> Too many characters for that sha1 value :)
>
> thanks,
>
> greg k-hj

Thanks for the feedback!
I assumed this tiny typo fix might not need a "Fixes:" tag since it
doesn’t really "fix" any functional issue—just let me know if you
disagree. I’m just beginning my kernel contribution journey, so I
appreciate any guidance.
Cheers,