linux-kernel - Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250522121056.685637cd@booty>
Date: Thu, 22 May 2025 12:10:56 +0200
From: Luca Ceresoli <luca.ceresoli@...tlin.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Cosmin Tanislav <demonsingur@...il.com>, Tomi Valkeinen
 <tomi.valkeinen@...asonboard.com>, Mauro Carvalho Chehab
 <mchehab@...nel.org>, Romain Gantois <romain.gantois@...tlin.com>, Arnd
 Bergmann <arnd@...db.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org
Subject: Re: [PATCH v5 7/9] i2c: atr: add flags parameter to i2c_atr_new()

On Thu, 22 May 2025 10:50:24 +0200
Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:

> On Wed, May 07, 2025 at 03:19:13PM +0300, Cosmin Tanislav wrote:
> > In preparation for adding multiple flags that change the behavior,
> > add a flags parameter to i2c_atr_new() and an i2c_atr_flags enum.
> > 
> > Signed-off-by: Cosmin Tanislav <demonsingur@...il.com>
> > Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> > Reviewed-by: Romain Gantois <romain.gantois@...tlin.com>  
> 
> How did you guys get it to build?

I haven't :-)

I just reviewed the code, and apparently gcc's parser is stricter than
I am.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com