linux-kernel - Re: [PATCH v5 1/9] i2c: atr: Fix lockdep for nested ATRs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aC74bCOXhPl5F5fX@shikoro>
Date: Thu, 22 May 2025 12:11:56 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Cosmin Tanislav <demonsingur@...il.com>,
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Romain Gantois <romain.gantois@...tlin.com>,
	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org,
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
Subject: Re: [PATCH v5 1/9] i2c: atr: Fix lockdep for nested ATRs

On Thu, May 22, 2025 at 12:07:13PM +0200, Luca Ceresoli wrote:
> On Thu, 22 May 2025 11:06:06 +0200
> Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
> 
> > On Wed, May 07, 2025 at 03:19:07PM +0300, Cosmin Tanislav wrote:
> > > From: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> > > 
> > > When we have an ATR, and another ATR as a subdevice of the first ATR,
> > > we get lockdep warnings for the i2c_atr.lock and
> > > i2c_atr_chan.orig_addrs_lock. This is because lockdep uses a static key
> > > for the locks, and doesn't see the locks of the separate ATR instances
> > > as separate.
> > > 
> > > Fix this by generating a dynamic lock key per lock instance.
> > > 
> > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>
> > > Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>  
> > 
> > Your SoB is missing. I will add it for you if you confirm here.
> 
> Mine? I didn't think it would be needed based on:

Ah, I was talking to Cosmin. Sorry if that wasn't clear.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)