linux-kernel - Re: [PATCH] spi: use container_of_cont() for to_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <174792306871.93788.12995435193325087617.b4-ty@kernel.org>
Date: Thu, 22 May 2025 15:11:08 +0100
From: Mark Brown <broonie@...nel.org>
To: linux-spi@...r.kernel.org, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: use container_of_cont() for to_spi_device()

On Thu, 22 May 2025 12:47:31 +0200, Greg Kroah-Hartman wrote:
> Some places in the spi core pass in a const pointer to a device and the
> default container_of() casts that away, which is not a good idea.
> Preserve the proper const attribute by using container_of_const() for
> to_spi_device() instead, which is what it was designed for.
> 
> Note, this removes the NULL check for a device pointer in the call, but
> no one was ever checking for that return value, and a device pointer
> should never be NULL overall anyway, so this should be a safe change.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: use container_of_cont() for to_spi_device()
      commit: 1007ae0d464ceb55a3740634790521d3543aaab9

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark