linux-kernel - Re: [PATCH] sched: Make clangd usable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDC8JsZetV-GHhG_@slm.duckdns.org>
Date: Fri, 23 May 2025 08:19:18 -1000
From: Tejun Heo <tj@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: mingo@...hat.com, juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, vschneid@...hat.com, rafael@...nel.org,
	viresh.kumar@...aro.org, mathieu.desnoyers@...icios.com,
	paulmck@...nel.org, hannes@...xchg.org, surenb@...gle.com,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Andrea Righi <arighi@...dia.com>
Subject: Re: [PATCH] sched: Make clangd usable

On Fri, May 23, 2025 at 06:48:08AM -1000, Tejun Heo wrote:
> On Fri, May 23, 2025 at 06:43:48PM +0200, Peter Zijlstra wrote:
> > 
> > Due to the weird Makefile setup of sched the various files do not
> > compile as stand alone units. The new generation of editors are trying
> > to do just this -- mostly to offer fancy things like completions but
> > also better syntax highlighting and code navigation.
> > 
> > Specifically, I've been playing around with neovim and clangd.
> > 
> > Setting up clangd on the kernel source is a giant pain in the arse
> > (this really should be improved), but once you do manage, you run into
> > dumb stuff like the above.
> > 
> > Fix up the scheduler files to at least pretend to work.
> > 
> > (this excludes ext because those include games are worse than average)
> 
> Yeah, ext needs to move the stuff that's shared between ext.c and ext_idle.c
> into ext.h. cc: Andrea.

Thinking more about it, I wonder whether what should happen is re-splitting
the includes and all that but add the combined compilation as a
default-enabled option, so that the files can be built separately at least
when verifying the source files are in sane states. Including the same files
multiple times don't really cost anything signficant, so that still
maintains the benefits of faster build speed. The way things are set up now,
the separation across files are bound to decay over time.

Thanks.

-- 
tejun