linux-kernel - Re: [PATCH v2 2/2] soc: qcom: fix endianness for QMI header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aDAOXo/ujOcefs04@FUE-ALEWI-WINX>
Date: Fri, 23 May 2025 07:57:50 +0200
From: Alexander Wilhelm <alexander.wilhelm@...termo.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] soc: qcom: fix endianness for QMI header

Am Thu, May 22, 2025 at 10:09:13PM +0300 schrieb Dmitry Baryshkov:
> On Thu, May 22, 2025 at 04:35:30PM +0200, Alexander Wilhelm wrote:
> > The members of QMI header have to be swapped on big endian platforms. Use
> > __le16 types instead of u16 ones.
> > 
> > Signed-off-by: Alexander Wilhelm <alexander.wilhelm@...termo.com>
> > ---
> >  drivers/soc/qcom/qmi_encdec.c    | 6 +++---
> >  drivers/soc/qcom/qmi_interface.c | 6 +++---
> >  include/linux/soc/qcom/qmi.h     | 6 +++---
> >  3 files changed, 9 insertions(+), 9 deletions(-)
> 
> Just out of curiosity, is there a usecase for running QMI helpers on BE
> platforms?

I'm not familiar with modems, but the wireless drivers ath11k and ath12k use the
QMI helpers while transferring the firmware and boardfile to the module. As an
example here is the log by probing ath12k device on big endian without a patch:

    ath12k_pci 0001:01:00.0: BAR 0: assigned [mem 0xc00000000-0xc001fffff 64bit]
    ath12k_pci 0001:01:00.0: MSI vectors: 1
    ath12k_pci 0001:01:00.0: Hardware name: qcn9274 hw2.0
    ath12k_pci 0001:01:00.0: FW Ind register request failed, result: 256, err: 512
    ath12k_pci 0001:01:00.0: qmi failed to send FW indication QMI:-22

Similar behavior is seen with ath11k drivers.


Best regards
Alexander Wilhelm